2023-10-20 12:21:40

by Gavrilov Ilia

Subject: [PATCH net-next] net: atm: Remove redundant check.

Checking the 'adev' variable is unnecessary,
because 'cdev' has already been checked earlier.

Found by InfoTeCS on behalf of Linux Verification Center
(linuxtesting.org) with SVACE.

Fixes: 656d98b09d57 ("[ATM]: basic sysfs support for ATM devices")
Signed-off-by: Gavrilov Ilia <[email protected]>
---
net/atm/atm_sysfs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c
index 466353b3dde4..54e7fb1a4ee5 100644
--- a/net/atm/atm_sysfs.c
+++ b/net/atm/atm_sysfs.c
@@ -116,8 +116,6 @@ static int atm_uevent(const struct device *cdev, struct kobj_uevent_env *env)
return -ENODEV;

adev = to_atm_dev(cdev);
- if (!adev)
- return -ENODEV;

if (add_uevent_var(env, "NAME=%s%d", adev->type, adev->number))
return -ENOMEM;
--
2.39.2

2023-10-23 07:50:51

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: atm: Remove redundant check.

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <[email protected]>:

On Fri, 20 Oct 2023 12:21:16 +0000 you wrote:
> Checking the 'adev' variable is unnecessary,
> because 'cdev' has already been checked earlier.
>
> Found by InfoTeCS on behalf of Linux Verification Center
> (linuxtesting.org) with SVACE.
>
> Fixes: 656d98b09d57 ("[ATM]: basic sysfs support for ATM devices")
> Signed-off-by: Gavrilov Ilia <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] net: atm: Remove redundant check.
https://git.kernel.org/netdev/net-next/c/92fc97ae9cfd

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html