2023-10-20 13:21:45

by Arnd Bergmann

Subject: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS

From: Arnd Bergmann <[email protected]>

Without this, the newly added driver fails to link:

aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe':
s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get'

Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/clk/meson/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
index c5303e4c16043..3c28560b0faba 100644
--- a/drivers/clk/meson/Kconfig
+++ b/drivers/clk/meson/Kconfig
@@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL
tristate "S4 SoC PLL clock controllers support"
depends on ARM64
default y
+ select COMMON_CLK_MESON_CLKC_UTILS
select COMMON_CLK_MESON_MPLL
select COMMON_CLK_MESON_PLL
select COMMON_CLK_MESON_REGMAP
--
2.39.2

2023-10-20 13:28:42

by Neil Armstrong

Subject: Re: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS

On 20/10/2023 15:19, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Without this, the newly added driver fails to link:
>
> aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe':
> s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get'
>
> Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/clk/meson/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> index c5303e4c16043..3c28560b0faba 100644
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL
> tristate "S4 SoC PLL clock controllers support"
> depends on ARM64
> default y
> + select COMMON_CLK_MESON_CLKC_UTILS
> select COMMON_CLK_MESON_MPLL
> select COMMON_CLK_MESON_PLL
> select COMMON_CLK_MESON_REGMAP

Reviewed-by: Neil Armstrong <[email protected]>

2023-10-20 13:37:41

by Jerome Brunet

Subject: Re: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS

On Fri 20 Oct 2023 at 15:19, Arnd Bergmann <[email protected]> wrote:

> From: Arnd Bergmann <[email protected]>
>
> Without this, the newly added driver fails to link:
>
> aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe':
> s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get'
>
> Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/clk/meson/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> index c5303e4c16043..3c28560b0faba 100644
> --- a/drivers/clk/meson/Kconfig
> +++ b/drivers/clk/meson/Kconfig
> @@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL
> tristate "S4 SoC PLL clock controllers support"
> depends on ARM64
> default y
> + select COMMON_CLK_MESON_CLKC_UTILS
> select COMMON_CLK_MESON_MPLL
> select COMMON_CLK_MESON_PLL
> select COMMON_CLK_MESON_REGMAP

Thx Arnd and sorry about this.

Reviewed-by: Jerome Brunet <[email protected]>

Stephen, do you mind taking this directly ?

2023-10-23 10:28:36

by Arnd Bergmann

Subject: Re: [PATCH] clk: meson: S4: select CONFIG_COMMON_CLK_MESON_CLKC_UTILS

On Fri, Oct 20, 2023, at 15:35, Jerome Brunet wrote:
> On Fri 20 Oct 2023 at 15:19, Arnd Bergmann <[email protected]> wrote:
>
>> From: Arnd Bergmann <[email protected]>
>>
>> Without this, the newly added driver fails to link:
>>
>> aarch64-linux-ld: drivers/clk/meson/s4-pll.o: in function `meson_s4_pll_probe':
>> s4-pll.c:(.text+0x13c): undefined reference to `meson_clk_hw_get'
>>
>> Fixes: e787c9c55edad ("clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver")
>> Signed-off-by: Arnd Bergmann <[email protected]>
>> ---
>> drivers/clk/meson/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
>> index c5303e4c16043..3c28560b0faba 100644
>> --- a/drivers/clk/meson/Kconfig
>> +++ b/drivers/clk/meson/Kconfig
>> @@ -149,6 +149,7 @@ config COMMON_CLK_S4_PLL
>> tristate "S4 SoC PLL clock controllers support"
>> depends on ARM64
>> default y
>> + select COMMON_CLK_MESON_CLKC_UTILS
>> select COMMON_CLK_MESON_MPLL
>> select COMMON_CLK_MESON_PLL
>> select COMMON_CLK_MESON_REGMAP
>
> Thx Arnd and sorry about this.
>
> Reviewed-by: Jerome Brunet <[email protected]>
>
> Stephen, do you mind taking this directly ?

I ran into the same bug with drivers/clk/meson/s4-peripherals.c,
sending a v2 of my patch to fix both at the same time, assuming
v1 has not been applied yet (it's not in today's linux-next).

Arnd