2023-10-23 02:16:29

by Seven Lee

[permalink] [raw]

Subject: [PATCH 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate selection

---

Add input with DMIC slew rate selection

Signed-off-by: Seven Lee <[email protected]>
---
.../devicetree/bindings/sound/nuvoton,nau8821.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
index 3e54abd4ca74..5f7f2eed4834 100644
--- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
+++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
@@ -89,6 +89,12 @@ properties:
$ref: /schemas/types.yaml#/definitions/uint32
default: 3072000

+ nuvoton,dmic-slew-rate-selection:
+ description: number from 0 to 7 that sets DMIC slew rate.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ maximum: 7
+ default: 0
+
nuvoton,left-input-single-end:
description: Enable left input with single-ended settings if set.
For the headset mic application, the single-ended control is
@@ -127,6 +133,7 @@ examples:
nuvoton,jack-insert-debounce = <7>;
nuvoton,jack-eject-debounce = <0>;
nuvoton,dmic-clk-threshold = <3072000>;
+ nuvoton,dmic-slew-rate-selection= <0>;
#sound-dai-cells = <0>;
};
};
--
2.25.1

2023-10-23 16:55:31

by Conor Dooley

[permalink] [raw]

Subject: Re: [PATCH 1/2] ASoC: dt-bindings: nau8821: Add DMIC slew rate selection

---

Hey,

On Mon, Oct 23, 2023 at 10:15:36AM +0800, Seven Lee wrote:
> Add input with DMIC slew rate selection
>
> Signed-off-by: Seven Lee <[email protected]>
> ---
> .../devicetree/bindings/sound/nuvoton,nau8821.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> index 3e54abd4ca74..5f7f2eed4834 100644
> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> @@ -89,6 +89,12 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> default: 3072000
>
> + nuvoton,dmic-slew-rate-selection:
> + description: number from 0 to 7 that sets DMIC slew rate.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + maximum: 7
> + default: 0

I'd much rather this was an enum of possible values in $unit, than what
appears to be values you want to write to a register.

Cheers,
Conor.

> +
> nuvoton,left-input-single-end:
> description: Enable left input with single-ended settings if set.
> For the headset mic application, the single-ended control is
> @@ -127,6 +133,7 @@ examples:
> nuvoton,jack-insert-debounce = <7>;
> nuvoton,jack-eject-debounce = <0>;
> nuvoton,dmic-clk-threshold = <3072000>;
> + nuvoton,dmic-slew-rate-selection= <0>;
> #sound-dai-cells = <0>;
> };
> };
> --
> 2.25.1
>

---

Attachments:

(No filename) (1.56 kB)
signature.asc (235.00 B)
Download all attachments