2023-10-23 00:06:47

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the pci tree

Hi all,

After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

ERROR: modpost: "dw_pcie_write_dbi2" [drivers/pci/controller/dwc/pcie-rcar-gen4.ko] undefined!

Caused by commit

8227bf7a81e6 ("PCI: rcar-gen4: Add R-Car Gen4 PCIe controller support for host mode")

or

d3c54d8ba855 ("PCI: rcar-gen4: Add endpoint mode support")

I have used the pci tree from next-20231020 for today.

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2023-10-23 07:30:46

by Yoshihiro Shimoda

[permalink] [raw]
Subject: RE: linux-next: build failure after merge of the pci tree

Hi Stephen,

> From: Stephen Rothwell, Sent: Monday, October 23, 2023 9:06 AM
>
> Hi all,
>
> After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> ERROR: modpost: "dw_pcie_write_dbi2" [drivers/pci/controller/dwc/pcie-rcar-gen4.ko] undefined!
>
> Caused by commit
>
> 8227bf7a81e6 ("PCI: rcar-gen4: Add R-Car Gen4 PCIe controller support for host mode")
>
> or
>
> d3c54d8ba855 ("PCI: rcar-gen4: Add endpoint mode support")
>
> I have used the pci tree from next-20231020 for today.

Thank you for the report!

Bjorn, Krzysztof, I should have added the following patch on patch-set v25.
However, I completely forgot it...
https://lore.kernel.org/linux-pci/[email protected]/

I confirmed that the patch above can be applied on the latest pci.git / next branch.
However, should I resend whole patches with the patch above as v26?

Best regards,
Yoshihiro Shimoda

> --
> Cheers,
> Stephen Rothwell

2023-10-23 07:35:01

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the pci tree

Hello,

> > Hi all,
> >
> > After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> >
> > ERROR: modpost: "dw_pcie_write_dbi2" [drivers/pci/controller/dwc/pcie-rcar-gen4.ko] undefined!
[...]

> However, I completely forgot it...

That's OK. Don't worry. :)

> https://lore.kernel.org/linux-pci/[email protected]/
>
> I confirmed that the patch above can be applied on the latest pci.git / next branch.

I will take care of it.

> However, should I resend whole patches with the patch above as v26?

No. There is no need to send another series.

Different question: aren't RCar systems based on Arm? I wonder why this
even built on a x86_64 - unless I am wrong about this.

Krzysztof

2023-10-23 09:36:55

by Yoshihiro Shimoda

[permalink] [raw]
Subject: RE: linux-next: build failure after merge of the pci tree

Hello Krzysztof,

> From: Krzysztof Wilczy?ski, Sent: Monday, October 23, 2023 4:35 PM
>
> > > Hi all,
> > >
> > > After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
> > > failed like this:
> > >
> > > ERROR: modpost: "dw_pcie_write_dbi2" [drivers/pci/controller/dwc/pcie-rcar-gen4.ko] undefined!
> [...]
>
> > However, I completely forgot it...
>
> That's OK. Don't worry. :)
>
> > https://lore.kernel.org/linux-pci/[email protected]/
> >
> > I confirmed that the patch above can be applied on the latest pci.git / next branch.
>
> I will take care of it.

Thank you very much for your support!

> > However, should I resend whole patches with the patch above as v26?
>
> No. There is no need to send another series.

I got it.

> Different question: aren't RCar systems based on Arm?

You're correct. R-Car systems based on Arm.

> I wonder why this
> even built on a x86_64 - unless I am wrong about this.

This is because I added COMPILE_TEST to the Kconfig like below:

---
config PCIE_RCAR_GEN4_HOST
tristate "Renesas R-Car Gen4 PCIe controller (host mode)"
depends on ARCH_RENESAS || COMPILE_TEST
---

Best regards,
Yoshihiro Shimoda

> Krzysztof

2023-10-23 12:57:18

by Krzysztof Wilczyński

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the pci tree

Hello,

> > > > After merging the pci tree, today's linux-next build (x86_64 allmodconfig)
> > > > failed like this:
> > > >
> > > > ERROR: modpost: "dw_pcie_write_dbi2" [drivers/pci/controller/dwc/pcie-rcar-gen4.ko] undefined!
> > [...]
> >
> > > However, I completely forgot it...
> >
> > That's OK. Don't worry. :)
> >
> > > https://lore.kernel.org/linux-pci/[email protected]/
> > >
> > > I confirmed that the patch above can be applied on the latest pci.git / next branch.
> >
> > I will take care of it.
>
> Thank you very much for your support!
[...]

Done. Applied to the following branch:

https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/log/?h=controller/rcar

Bjorn will push updated next when he has a moment.

[...]
> This is because I added COMPILE_TEST to the Kconfig like below:
>
> ---
> config PCIE_RCAR_GEN4_HOST
> tristate "Renesas R-Car Gen4 PCIe controller (host mode)"
> depends on ARCH_RENESAS || COMPILE_TEST

Ah yes, sorry! I should have assumed as much. :) Thank you!

Krzysztof