Hi all,
After merging the ftrace tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
arch/powerpc/kernel/setup-common.c:604:10: error: 'struct seq_buf' has no member named 'readpos'
604 | .readpos = 0,
| ^~~~~~~
arch/powerpc/kernel/setup-common.c:604:20: error: excess elements in struct initializer [-Werror]
604 | .readpos = 0,
| ^
arch/powerpc/kernel/setup-common.c:604:20: note: (near initialization for 'ppc_hw_desc')
cc1: all warnings being treated as errors
Caused by commit
d0ed46b60396 ("tracing: Move readpos from seq_buf to trace_seq")
I have used the ftrace tree from next-20231020 for today.
--
Cheers,
Stephen Rothwell
On Mon, Oct 23, 2023 at 01:30:33PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the ftrace tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> arch/powerpc/kernel/setup-common.c:604:10: error: 'struct seq_buf' has no member named 'readpos'
> 604 | .readpos = 0,
This would fix it.
diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index 2f1026fba00d..34975532e44c 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -601,7 +601,6 @@ struct seq_buf ppc_hw_desc __initdata = {
.buffer = ppc_hw_desc_buf,
.size = sizeof(ppc_hw_desc_buf),
.len = 0,
- .readpos = 0,
};
static __init void probe_machine(void)
Steven, do you prefer fixup patches like this, or do you want a v3 that
includes this?
On Mon, 23 Oct 2023 04:32:24 +0100
Matthew Wilcox <[email protected]> wrote:
> Steven, do you prefer fixup patches like this, or do you want a v3 that
> includes this?
Please send a fixup patch. I don't like to rebase my for-next branch.
Thanks,
-- Steve
Hi all,
On Mon, 23 Oct 2023 13:30:33 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the ftrace tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> arch/powerpc/kernel/setup-common.c:604:10: error: 'struct seq_buf' has no member named 'readpos'
> 604 | .readpos = 0,
> | ^~~~~~~
> arch/powerpc/kernel/setup-common.c:604:20: error: excess elements in struct initializer [-Werror]
> 604 | .readpos = 0,
> | ^
> arch/powerpc/kernel/setup-common.c:604:20: note: (near initialization for 'ppc_hw_desc')
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> d0ed46b60396 ("tracing: Move readpos from seq_buf to trace_seq")
>
> I have used the ftrace tree from next-20231020 for today.
This is still failing ...
--
Cheers,
Stephen Rothwell
On Thu, 26 Oct 2023 12:18:16 +1100
Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> On Mon, 23 Oct 2023 13:30:33 +1100 Stephen Rothwell <[email protected]> wrote:
> >
> > After merging the ftrace tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > arch/powerpc/kernel/setup-common.c:604:10: error: 'struct seq_buf' has no member named 'readpos'
> > 604 | .readpos = 0,
> > | ^~~~~~~
> > arch/powerpc/kernel/setup-common.c:604:20: error: excess elements in struct initializer [-Werror]
> > 604 | .readpos = 0,
> > | ^
> > arch/powerpc/kernel/setup-common.c:604:20: note: (near initialization for 'ppc_hw_desc')
> > cc1: all warnings being treated as errors
> >
> > Caused by commit
> >
> > d0ed46b60396 ("tracing: Move readpos from seq_buf to trace_seq")
> >
> > I have used the ftrace tree from next-20231020 for today.
>
> This is still failing ...
>
Ah, I never pushed it up from trace/for-next to for-next. Thanks for the reminder.
I'll do that now.
-- Steve