2023-10-20 09:32:44

by Kunwu Chan

Subject: [PATCH] treewide: Spelling fix in comment

reques -> request

Fixes: 09dde54c6a69 ("PS3: gelic: Add wireless support for PS3")
Signed-off-by: Kunwu Chan <[email protected]>
---
drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
index dc14a66583ff..44488c153ea2 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
@@ -1217,7 +1217,7 @@ static int gelic_wl_set_encodeext(struct net_device *netdev,
key_index = wl->current_key;

if (!enc->length && (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY)) {
- /* reques to change default key index */
+ /* request to change default key index */
pr_debug("%s: request to change default key to %d\n",
__func__, key_index);
wl->current_key = key_index;
--
2.34.1

2023-10-20 11:08:01

by Geert Uytterhoeven

Subject: Re: [PATCH] treewide: Spelling fix in comment

Hi Kunwu,

Thanks for your patch!

This is not a treewide change. Hence the oneline-summary should be
something prefixed by "[net-next] ps3_gelic"

On Fri, Oct 20, 2023 at 11:32 AM Kunwu Chan <[email protected]> wrote:
> reques -> request
>
> Fixes: 09dde54c6a69 ("PS3: gelic: Add wireless support for PS3")

No need for a Fixes tag for a spelling fix in a comment.

> Signed-off-by: Kunwu Chan <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

> --- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
> +++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
> @@ -1217,7 +1217,7 @@ static int gelic_wl_set_encodeext(struct net_device *netdev,
> key_index = wl->current_key;
>
> if (!enc->length && (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY)) {
> - /* reques to change default key index */
> + /* request to change default key index */
> pr_debug("%s: request to change default key to %d\n",
> __func__, key_index);
> wl->current_key = key_index;

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-10-21 00:04:35

by Jakub Kicinski

Subject: Re: [PATCH] treewide: Spelling fix in comment

On Fri, 20 Oct 2023 17:31:56 +0800 Kunwu Chan wrote:
> reques -> request
>
> Fixes: 09dde54c6a69 ("PS3: gelic: Add wireless support for PS3")
> Signed-off-by: Kunwu Chan <[email protected]>

Appears to have been applied to net, thank you!

2023-10-23 09:57:08

by Kunwu Chan

Subject: Re: [PATCH] treewide: Spelling fix in comment

Hi Geert,
Thank you very much for your advice, I am a rookie, I am not familiar
with many aspects, and I need to learn more. I'll modify the patch.

On 2023/10/20 19:07, Geert Uytterhoeven wrote:
> Hi Kunwu,
>
> Thanks for your patch!
>
> This is not a treewide change. Hence the oneline-summary should be
> something prefixed by "[net-next] ps3_gelic"
>
> On Fri, Oct 20, 2023 at 11:32 AM Kunwu Chan <[email protected]> wrote:
>> reques -> request
>>
>> Fixes: 09dde54c6a69 ("PS3: gelic: Add wireless support for PS3")
>
> No need for a Fixes tag for a spelling fix in a comment.
>
>> Signed-off-by: Kunwu Chan <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
>> --- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
>> +++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
>> @@ -1217,7 +1217,7 @@ static int gelic_wl_set_encodeext(struct net_device *netdev,
>> key_index = wl->current_key;
>>
>> if (!enc->length && (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY)) {
>> - /* reques to change default key index */
>> + /* request to change default key index */
>> pr_debug("%s: request to change default key to %d\n",
>> __func__, key_index);
>> wl->current_key = key_index;
>
> Gr{oetje,eeting}s,
>
> Geert
>

2023-10-23 09:58:22

by Kunwu Chan

Subject: [PATCH v2] treewide: Spelling fix in comment

reques -> request

Signed-off-by: Kunwu Chan <[email protected]>
---
drivers/net/ethernet/toshiba/ps3_gelic_wireless.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
index dc14a66583ff..44488c153ea2 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_wireless.c
@@ -1217,7 +1217,7 @@ static int gelic_wl_set_encodeext(struct net_device *netdev,
key_index = wl->current_key;

if (!enc->length && (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY)) {
- /* reques to change default key index */
+ /* request to change default key index */
pr_debug("%s: request to change default key to %d\n",
__func__, key_index);
wl->current_key = key_index;
--
2.34.1