2023-10-23 11:23:18

by wuqiang.matt

Subject: [PATCH v1] kprobes: unused header files removed

As kernel test robot reported, lib/test_objpool.c (trace:probes/for-next)
has linux/version.h included, but version.h is not used at all. Then more
unused headers are found in test_objpool.c and rethook.c, and all of them
should be removed.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Signed-off-by: wuqiang.matt <[email protected]>
---
kernel/trace/rethook.c | 2 --
lib/test_objpool.c | 6 ------
2 files changed, 8 deletions(-)

diff --git a/kernel/trace/rethook.c b/kernel/trace/rethook.c
index 13c8e6773892..6fd7d4ecbbc6 100644
--- a/kernel/trace/rethook.c
+++ b/kernel/trace/rethook.c
@@ -8,8 +8,6 @@
#include <linux/preempt.h>
#include <linux/rethook.h>
#include <linux/slab.h>
-#include <linux/sort.h>
-#include <linux/smp.h>

/* Return hook list (shadow stack by list) */

diff --git a/lib/test_objpool.c b/lib/test_objpool.c
index 98b5b37b6eea..a94078402138 100644
--- a/lib/test_objpool.c
+++ b/lib/test_objpool.c
@@ -6,21 +6,15 @@
* Copyright: [email protected]
*/

-#include <linux/version.h>
#include <linux/errno.h>
#include <linux/module.h>
#include <linux/moduleparam.h>
-#include <linux/sched.h>
-#include <linux/cpumask.h>
#include <linux/completion.h>
#include <linux/kthread.h>
-#include <linux/cpu.h>
-#include <linux/cpuset.h>
#include <linux/slab.h>
#include <linux/vmalloc.h>
#include <linux/delay.h>
#include <linux/hrtimer.h>
-#include <linux/interrupt.h>
#include <linux/objpool.h>

#define OT_NR_MAX_BULK (16)
--
2.40.1

2023-10-24 00:52:41

by Masami Hiramatsu

Subject: Re: [PATCH v1] kprobes: unused header files removed

On Mon, 23 Oct 2023 19:22:45 +0800
"wuqiang.matt" <[email protected]> wrote:

> As kernel test robot reported, lib/test_objpool.c (trace:probes/for-next)
> has linux/version.h included, but version.h is not used at all. Then more
> unused headers are found in test_objpool.c and rethook.c, and all of them
> should be removed.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

Looks good to me.

Acked-by: Masami Hiramatsu (Google) <[email protected]>

Thanks,

>
> Signed-off-by: wuqiang.matt <[email protected]>
> ---
> kernel/trace/rethook.c | 2 --
> lib/test_objpool.c | 6 ------
> 2 files changed, 8 deletions(-)
>
> diff --git a/kernel/trace/rethook.c b/kernel/trace/rethook.c
> index 13c8e6773892..6fd7d4ecbbc6 100644
> --- a/kernel/trace/rethook.c
> +++ b/kernel/trace/rethook.c
> @@ -8,8 +8,6 @@
> #include <linux/preempt.h>
> #include <linux/rethook.h>
> #include <linux/slab.h>
> -#include <linux/sort.h>
> -#include <linux/smp.h>
>
> /* Return hook list (shadow stack by list) */
>
> diff --git a/lib/test_objpool.c b/lib/test_objpool.c
> index 98b5b37b6eea..a94078402138 100644
> --- a/lib/test_objpool.c
> +++ b/lib/test_objpool.c
> @@ -6,21 +6,15 @@
> * Copyright: [email protected]
> */
>
> -#include <linux/version.h>
> #include <linux/errno.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> -#include <linux/sched.h>
> -#include <linux/cpumask.h>
> #include <linux/completion.h>
> #include <linux/kthread.h>
> -#include <linux/cpu.h>
> -#include <linux/cpuset.h>
> #include <linux/slab.h>
> #include <linux/vmalloc.h>
> #include <linux/delay.h>
> #include <linux/hrtimer.h>
> -#include <linux/interrupt.h>
> #include <linux/objpool.h>
>
> #define OT_NR_MAX_BULK (16)
> --
> 2.40.1
>


--
Masami Hiramatsu (Google) <[email protected]>