2023-10-23 03:29:51

by Bagas Sanjaya

[permalink] [raw]
Subject: [PATCH net v2 0/2] MAINTAINERS: WWAN subsystem changes

I have to make this little MAINTAINERS patch series when I was dealing
with a regression involving Intel WWAN IOSM driver [1]. The culprit
author was (AFAIK) MIA as well as its subsystem mailing list down.
So here is the series.

Changes since v1 [2]:
* Alphabetically by surname sort CREDITS entry

[1]: https://lore.kernel.org/lkml/[email protected]/
[2]: https://lore.kernel.org/lkml/[email protected]/

Bagas Sanjaya (2):
MAINTAINERS: Move M Chetan Kumar to CREDITS
MAINTAINERS: Remove [email protected] mailing list

CREDITS | 5 +++++
MAINTAINERS | 7 +------
2 files changed, 6 insertions(+), 6 deletions(-)


base-commit: d2a0fc372aca561556e765d0a9ec365c7c12f0ad
--
An old man doll... just what I always wanted! - Clara


2023-10-23 03:30:03

by Bagas Sanjaya

[permalink] [raw]
Subject: [PATCH net v2 1/2] MAINTAINERS: Move M Chetan Kumar to CREDITS

Emails to him bounce with 550 error code:

```
5.1.0 - Unknown address error 550-'5.1.1 <[email protected]>: Recipient address rejected: User unknown in virtual mailbox table'
```

It looks like he had left Intel, so move him to CREDITS.

Signed-off-by: Bagas Sanjaya <[email protected]>
---
He is still listed by scripts/get_maintainer.pl, though (due to significant
contribution):

```
$ scripts/get_maintainer.pl drivers/net/wwan/iosm/
...
M Chetan Kumar <[email protected]> (commit_signer:15/23=65%,authored:14/23=61%)
...
```

If no one steps up maintaining IOSM, should INTEL WWAN IOSM DRIVER entry
be removed then to get rid of him, like in [1]?

[1]: https://lore.kernel.org/lkml/[email protected]/

CREDITS | 5 +++++
MAINTAINERS | 2 --
2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/CREDITS b/CREDITS
index f33a33fd237170..0472398b6aa7e9 100644
--- a/CREDITS
+++ b/CREDITS
@@ -2191,6 +2191,11 @@ D: pirq addr, CS5535 alsa audio driver
S: Gurgaon, India
S: Kuala Lumpur, Malaysia

+N: M Chetan Kumar
+E: <[email protected]>
+D: Intel WWAN IOSM driver
+D: Mediatek T7XX 5G WWAN reviewer
+
N: Mohit Kumar
D: ST Microelectronics SPEAr13xx PCI host bridge driver
D: Synopsys DesignWare PCI host bridge driver
diff --git a/MAINTAINERS b/MAINTAINERS
index 7a7bd8bd80e9f2..08a7be6a5680ed 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10879,7 +10879,6 @@ S: Maintained
F: drivers/platform/x86/intel/wmi/thunderbolt.c

INTEL WWAN IOSM DRIVER
-M: M Chetan Kumar <[email protected]>
M: Intel Corporation <[email protected]>
L: [email protected]
S: Maintained
@@ -13504,7 +13503,6 @@ M: Chandrashekar Devegowda <[email protected]>
M: Intel Corporation <[email protected]>
R: Chiranjeevi Rapolu <[email protected]>
R: Liu Haijun <[email protected]>
-R: M Chetan Kumar <[email protected]>
R: Ricardo Martinez <[email protected]>
L: [email protected]
S: Supported
--
An old man doll... just what I always wanted! - Clara

2023-10-23 16:38:51

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net v2 1/2] MAINTAINERS: Move M Chetan Kumar to CREDITS

On Mon, 23 Oct 2023 10:29:04 +0700 Bagas Sanjaya wrote:
> M Chetan Kumar <[email protected]> (commit_signer:15/23=65%,authored:14/23=61%)

14 patches authored and 15 signed off?
Let me be more clear this time - nak, please drop this patch.
--
pw-bot: cr

2023-10-24 00:11:56

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH net v2 1/2] MAINTAINERS: Move M Chetan Kumar to CREDITS

On 23/10/2023 23:38, Jakub Kicinski wrote:
> On Mon, 23 Oct 2023 10:29:04 +0700 Bagas Sanjaya wrote:
>> M Chetan Kumar <[email protected]> (commit_signer:15/23=65%,authored:14/23=61%)
>
> 14 patches authored and 15 signed off?
> Let me be more clear this time - nak, please drop this patch.

Or maybe as well drop INTEL WWAN IOSM DRIVER entry (and let
WWAN subsystem maintainers handle it)? I don't want
people get their inboxes spammed with bounces against
his addresses, though.

He's now in a state of limbo. He has significant contribution
(and gets listed by get_maintainer script with (AFAIK) no way
to filter him out), yet emails to him bounces. What will be
the resolution then?

--
An old man doll... just what I always wanted! - Clara

2023-10-24 01:52:36

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net v2 1/2] MAINTAINERS: Move M Chetan Kumar to CREDITS

On Tue, 24 Oct 2023 07:11:12 +0700 Bagas Sanjaya wrote:
> > 14 patches authored and 15 signed off?
> > Let me be more clear this time - nak, please drop this patch.
>
> Or maybe as well drop INTEL WWAN IOSM DRIVER entry (and let
> WWAN subsystem maintainers handle it)? I don't want
> people get their inboxes spammed with bounces against
> his addresses, though.

Right, sorry, still delete him from the MAINTAINERS.
Just don't add him to the CREDITS.

> He's now in a state of limbo. He has significant contribution
> (and gets listed by get_maintainer script with (AFAIK) no way
> to filter him out), yet emails to him bounces. What will be
> the resolution then?

Yes :( Not much we can do about that (even if we drop him from
maintainers all fixes will CC him based on the sign-off tags).

2023-10-24 07:35:50

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH net v2 1/2] MAINTAINERS: Move M Chetan Kumar to CREDITS

On Mon, Oct 23, 2023 at 06:52:21PM -0700, Jakub Kicinski wrote:
> On Tue, 24 Oct 2023 07:11:12 +0700 Bagas Sanjaya wrote:
> > > 14 patches authored and 15 signed off?
> > > Let me be more clear this time - nak, please drop this patch.
> >
> > Or maybe as well drop INTEL WWAN IOSM DRIVER entry (and let
> > WWAN subsystem maintainers handle it)? I don't want
> > people get their inboxes spammed with bounces against
> > his addresses, though.
>
> Right, sorry, still delete him from the MAINTAINERS.
> Just don't add him to the CREDITS.
>
> > He's now in a state of limbo. He has significant contribution
> > (and gets listed by get_maintainer script with (AFAIK) no way
> > to filter him out), yet emails to him bounces. What will be
> > the resolution then?
>
> Yes :( Not much we can do about that (even if we drop him from
> maintainers all fixes will CC him based on the sign-off tags).

OK, thanks!

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (996.00 B)
signature.asc (235.00 B)
Download all attachments

2023-10-24 07:41:04

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH net v2 1/2] MAINTAINERS: Move M Chetan Kumar to CREDITS

On Mon, 2023-10-23 at 18:52 -0700, Jakub Kicinski wrote:
>
> > He's now in a state of limbo. He has significant contribution
> > (and gets listed by get_maintainer script with (AFAIK) no way
> > to filter him out), yet emails to him bounces. What will be
> > the resolution then?
>
> Yes :( Not much we can do about that (even if we drop him from
> maintainers all fixes will CC him based on the sign-off tags).

I was hoping he'd chime in here - I did manage to find him at his
personal address, but I didn't want to just add his personal address to
the public list.

If he's OK with exposing his personal (or new work?) address I guess we
could add him to the .mailmap, to address this particular problem.

Anyway I've BCC'ed him now (Hi Chetan :) ), but he had also said he was
checking with his new work about this all.

johannes