2023-10-24 16:07:32

by Andy Shevchenko

Subject: [PATCH v1 1/1] mfd: lpc_ich: Mark *_gpio_offsets data with const

There is no reason why the GPIO resource offsets should not be const.
Mark them accordingly and update a qualifier in struct lpc_ich_gpio_info
definition.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/mfd/lpc_ich.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index ea5f01e07daf..73a0e7f9bd31 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -139,7 +139,7 @@ struct lpc_ich_gpio_info {
size_t nr_devices;
struct resource **resources;
size_t nr_resources;
- resource_size_t *offsets;
+ const resource_size_t *offsets;
};

#define APL_GPIO_NORTH 0
@@ -151,7 +151,7 @@ struct lpc_ich_gpio_info {
#define APL_GPIO_NR_RESOURCES 4

/* Offset data for Apollo Lake GPIO controllers */
-static resource_size_t apl_gpio_offsets[APL_GPIO_NR_RESOURCES] = {
+static const resource_size_t apl_gpio_offsets[APL_GPIO_NR_RESOURCES] = {
[APL_GPIO_NORTH] = 0xc50000,
[APL_GPIO_NORTHWEST] = 0xc40000,
[APL_GPIO_WEST] = 0xc70000,
@@ -233,7 +233,7 @@ static const struct lpc_ich_gpio_info apl_gpio_info = {
#define DNV_GPIO_NR_RESOURCES 2

/* Offset data for Denverton GPIO controllers */
-static resource_size_t dnv_gpio_offsets[DNV_GPIO_NR_RESOURCES] = {
+static const resource_size_t dnv_gpio_offsets[DNV_GPIO_NR_RESOURCES] = {
[DNV_GPIO_NORTH] = 0xc20000,
[DNV_GPIO_SOUTH] = 0xc50000,
};
--
2.40.0.1.gaa8946217a0b

2023-10-25 12:20:20

by Lee Jones

Subject: Re: (subset) [PATCH v1 1/1] mfd: lpc_ich: Mark *_gpio_offsets data with const

On Tue, 24 Oct 2023 19:06:50 +0300, Andy Shevchenko wrote:
> There is no reason why the GPIO resource offsets should not be const.
> Mark them accordingly and update a qualifier in struct lpc_ich_gpio_info
> definition.
>
>

Applied, thanks!

[1/1] mfd: lpc_ich: Mark *_gpio_offsets data with const
commit: 41536c17303d087d7b18a5f6ba45b2c1d17f1483

--
Lee Jones [李琼斯]