This series adds a common samsung-matisse dtsi and reworks
samsung-matisse-wifi to use it, and introduces samsung-matisselte. I
choose matisselte over matisse-lte as this is how most other devices
(klte, s3ve3g) do it and it is the codename that Samsung gave the
device. See individual commits for more information.
---
Changes since v1:
- Rebased on latest linux-next
- Added qcom,msm8226 compatible to matisselte inspired by recent Lumia
830 patch. This is done as in v1, the patch was rejected because I
included the msm8226 dtsi despite not marking matisselte as
compatible with msm8226, and I was not sure how to resolve that. As
such, I'm copying what was done in the Lumia 830 (microsoft-tesla)
patch given that it was accepted.
Changes since v2:
- Updated commit message for UART patch to explain why it was added.
- Gave more flags to git to provide a hopefully more readable patch.
Stefan Hansson (4):
ARM: dts: qcom: samsung-matisse-common: Add initial common device tree
dt-bindings: arm: qcom: Add Samsung Galaxy Tab 4 10.1 LTE
ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 10.1 LTE
(SM-T535)
ARM: dts: qcom: samsung-matisse-common: Add UART
.../devicetree/bindings/arm/qcom.yaml | 1 +
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom-apq8026-samsung-matisse-wifi.dts | 589 +++---------------
... qcom-msm8226-samsung-matisse-common.dtsi} | 59 +-
.../qcom/qcom-msm8926-samsung-matisselte.dts | 36 ++
5 files changed, 117 insertions(+), 569 deletions(-)
rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (89%)
copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts => qcom-msm8226-samsung-matisse-common.dtsi} (90%)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
--
2.41.0
Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
based on the MSM8926 platform.
Signed-off-by: Stefan Hansson <[email protected]>
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../qcom/qcom-msm8926-samsung-matisselte.dts | 36 +++++++++++++++++++
2 files changed, 37 insertions(+)
create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index a3d293e40820..cab35eeb30f6 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-msm8916-samsung-serranove.dtb \
qcom-msm8926-microsoft-superman-lte.dtb \
qcom-msm8926-microsoft-tesla.dtb \
+ qcom-msm8926-samsung-matisselte.dtb \
qcom-msm8960-cdp.dtb \
qcom-msm8960-samsung-expressatt.dtb \
qcom-msm8974-lge-nexus5-hammerhead.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
new file mode 100644
index 000000000000..6e25b1a74ce5
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
@@ -0,0 +1,36 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2022, Matti Lehtimäki <[email protected]>
+ * Copyright (c) 2023, Stefan Hansson <[email protected]>
+ */
+
+/dts-v1/;
+
+#include "qcom-msm8226-samsung-matisse-common.dtsi"
+
+/ {
+ model = "Samsung Galaxy Tab 4 10.1 LTE";
+ compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
+ chassis-type = "tablet";
+};
+
+&pm8226_l3 {
+ regulator-max-microvolt = <1350000>;
+};
+
+&pm8226_s4 {
+ regulator-max-microvolt = <2200000>;
+};
+
+®_tsp_3p3v {
+ gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
+};
+
+&sdhc_2 {
+ /* SD card fails to probe with error -110 */
+ status = "disabled";
+};
+
+&tsp_en1_default_state {
+ pins = "gpio32";
+};
--
2.41.0
On 25/10/2023 10:37, Stefan Hansson wrote:
> This series adds a common samsung-matisse dtsi and reworks
> samsung-matisse-wifi to use it, and introduces samsung-matisselte. I
> choose matisselte over matisse-lte as this is how most other devices
> (klte, s3ve3g) do it and it is the codename that Samsung gave the
> device. See individual commits for more information.
>
> ---
> Changes since v1:
>
> - Rebased on latest linux-next
> - Added qcom,msm8226 compatible to matisselte inspired by recent Lumia
> 830 patch. This is done as in v1, the patch was rejected because I
> included the msm8226 dtsi despite not marking matisselte as
> compatible with msm8226, and I was not sure how to resolve that. As
> such, I'm copying what was done in the Lumia 830 (microsoft-tesla)
> patch given that it was accepted.
One version per day, so you won't ignore tags.
Best regards,
Krzysztof
On 2023-10-25 10:48, Krzysztof Kozlowski wrote:
> On 25/10/2023 10:37, Stefan Hansson wrote:
>> This series adds a common samsung-matisse dtsi and reworks
>> samsung-matisse-wifi to use it, and introduces samsung-matisselte. I
>> choose matisselte over matisse-lte as this is how most other devices
>> (klte, s3ve3g) do it and it is the codename that Samsung gave the
>> device. See individual commits for more information.
>>
>> ---
>> Changes since v1:
>>
>> - Rebased on latest linux-next
>> - Added qcom,msm8226 compatible to matisselte inspired by recent Lumia
>> 830 patch. This is done as in v1, the patch was rejected because I
>> included the msm8226 dtsi despite not marking matisselte as
>> compatible with msm8226, and I was not sure how to resolve that. As
>> such, I'm copying what was done in the Lumia 830 (microsoft-tesla)
>> patch given that it was accepted.
>
> One version per day, so you won't ignore tags.
Sorry, I don't understand. Could you clarify what you mean? Thanks in
advance.
> Best regards,
> Krzysztof
>
On 25/10/2023 10:52, Stefan Hansson wrote:
>
>
> On 2023-10-25 10:48, Krzysztof Kozlowski wrote:
>> On 25/10/2023 10:37, Stefan Hansson wrote:
>>> This series adds a common samsung-matisse dtsi and reworks
>>> samsung-matisse-wifi to use it, and introduces samsung-matisselte. I
>>> choose matisselte over matisse-lte as this is how most other devices
>>> (klte, s3ve3g) do it and it is the codename that Samsung gave the
>>> device. See individual commits for more information.
>>>
>>> ---
>>> Changes since v1:
>>>
>>> - Rebased on latest linux-next
>>> - Added qcom,msm8226 compatible to matisselte inspired by recent Lumia
>>> 830 patch. This is done as in v1, the patch was rejected because I
>>> included the msm8226 dtsi despite not marking matisselte as
>>> compatible with msm8226, and I was not sure how to resolve that. As
>>> such, I'm copying what was done in the Lumia 830 (microsoft-tesla)
>>> patch given that it was accepted.
>>
>> One version per day, so you won't ignore tags.
>
> Sorry, I don't understand. Could you clarify what you mean? Thanks in
> advance.
Do not send more than one version of your patchset per 24h, if your
patchset is bigger than one patch.
Best regards,
Krzysztof
On 25.10.2023 10:37, Stefan Hansson wrote:
> Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
> based on the MSM8926 platform.
>
> Signed-off-by: Stefan Hansson <[email protected]>
> ---
> arch/arm/boot/dts/qcom/Makefile | 1 +
> .../qcom/qcom-msm8926-samsung-matisselte.dts | 36 +++++++++++++++++++
> 2 files changed, 37 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index a3d293e40820..cab35eeb30f6 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-msm8916-samsung-serranove.dtb \
> qcom-msm8926-microsoft-superman-lte.dtb \
> qcom-msm8926-microsoft-tesla.dtb \
> + qcom-msm8926-samsung-matisselte.dtb \
> qcom-msm8960-cdp.dtb \
> qcom-msm8960-samsung-expressatt.dtb \
> qcom-msm8974-lge-nexus5-hammerhead.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
> new file mode 100644
> index 000000000000..6e25b1a74ce5
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
> @@ -0,0 +1,36 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2022, Matti Lehtimäki <[email protected]>
> + * Copyright (c) 2023, Stefan Hansson <[email protected]>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226-samsung-matisse-common.dtsi"
> +
> +/ {
> + model = "Samsung Galaxy Tab 4 10.1 LTE";
> + compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
> + chassis-type = "tablet";
> +};
> +
> +&pm8226_l3 {
> + regulator-max-microvolt = <1350000>;
> +};
> +
> +&pm8226_s4 {
> + regulator-max-microvolt = <2200000>;
> +};
> +
> +®_tsp_3p3v {
> + gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
> +};
> +
> +&sdhc_2 {
> + /* SD card fails to probe with error -110 */
> + status = "disabled";
Can you give us some logs?
Konrad
On 2023-10-31 12:08, Konrad Dybcio wrote:
> On 25.10.2023 10:37, Stefan Hansson wrote:
>> Add a device tree for the Samsung Galaxy Tab 4 10.1 (SM-T535) LTE tablet
>> based on the MSM8926 platform.
>>
>> Signed-off-by: Stefan Hansson <[email protected]>
>> ---
>> arch/arm/boot/dts/qcom/Makefile | 1 +
>> .../qcom/qcom-msm8926-samsung-matisselte.dts | 36 +++++++++++++++++++
>> 2 files changed, 37 insertions(+)
>> create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>>
>> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
>> index a3d293e40820..cab35eeb30f6 100644
>> --- a/arch/arm/boot/dts/qcom/Makefile
>> +++ b/arch/arm/boot/dts/qcom/Makefile
>> @@ -34,6 +34,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>> qcom-msm8916-samsung-serranove.dtb \
>> qcom-msm8926-microsoft-superman-lte.dtb \
>> qcom-msm8926-microsoft-tesla.dtb \
>> + qcom-msm8926-samsung-matisselte.dtb \
>> qcom-msm8960-cdp.dtb \
>> qcom-msm8960-samsung-expressatt.dtb \
>> qcom-msm8974-lge-nexus5-hammerhead.dtb \
>> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>> new file mode 100644
>> index 000000000000..6e25b1a74ce5
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-samsung-matisselte.dts
>> @@ -0,0 +1,36 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2022, Matti Lehtimäki <[email protected]>
>> + * Copyright (c) 2023, Stefan Hansson <[email protected]>
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "qcom-msm8226-samsung-matisse-common.dtsi"
>> +
>> +/ {
>> + model = "Samsung Galaxy Tab 4 10.1 LTE";
>> + compatible = "samsung,matisselte", "qcom,msm8926", "qcom,msm8226";
>> + chassis-type = "tablet";
>> +};
>> +
>> +&pm8226_l3 {
>> + regulator-max-microvolt = <1350000>;
>> +};
>> +
>> +&pm8226_s4 {
>> + regulator-max-microvolt = <2200000>;
>> +};
>> +
>> +®_tsp_3p3v {
>> + gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
>> +};
>> +
>> +&sdhc_2 {
>> + /* SD card fails to probe with error -110 */
>> + status = "disabled";
> Can you give us some logs?
I tested it again just now, and it worked without issues. Maybe I used a
defective SD card to test it or hadn't inserted it properly. I'll send
another revision fixing this.
> Konrad
Stefan