2023-10-26 19:14:44

by Hsin-Yi Wang

[permalink] [raw]
Subject: [PATCH v4 0/7] Add a few mt8183 follower boards.

Add makomo, pico, and katsu which are mt8183 followers.

v4: based on https://lore.kernel.org/all/[email protected]/

Hsin-Yi Wang (7):
arm64: dts: mt8183: kukui: Fix underscores in node names
dt-bindings: arm64: mediatek: Add mt8183-kukui-katsu
arm64: dts: mt8183: Add kukui katsu board
dt-bindings: arm64: mediatek: Add mt8183-kukui-jacuzzi-makomo
arm64: dts: mt8183: Add jacuzzi makomo board
dt-bindings: arm64: mediatek: Add mt8183-kukui-jacuzzi-pico
arm64: dts: mt8183: Add jacuzzi pico/pico6 board

.../devicetree/bindings/arm/mediatek.yaml | 21 ++++
arch/arm64/boot/dts/mediatek/Makefile | 6 +
.../mt8183-kukui-jacuzzi-makomo-sku0.dts | 24 ++++
.../mt8183-kukui-jacuzzi-makomo-sku1.dts | 24 ++++
.../mediatek/mt8183-kukui-jacuzzi-pico.dts | 36 ++++++
.../mediatek/mt8183-kukui-jacuzzi-pico6.dts | 110 ++++++++++++++++++
.../dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 6 +-
.../mediatek/mt8183-kukui-kakadu-sku22.dts | 18 +++
.../boot/dts/mediatek/mt8183-kukui-kakadu.dts | 18 +++
.../dts/mediatek/mt8183-kukui-kakadu.dtsi | 14 +--
.../dts/mediatek/mt8183-kukui-katsu-sku32.dts | 36 ++++++
.../dts/mediatek/mt8183-kukui-katsu-sku38.dts | 40 +++++++
.../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 94 +++++++--------
13 files changed, 384 insertions(+), 63 deletions(-)
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-makomo-sku0.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-makomo-sku1.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-katsu-sku32.dts
create mode 100644 arch/arm64/boot/dts/mediatek/mt8183-kukui-katsu-sku38.dts

--
2.42.0.820.g83a721a137-goog


2023-10-26 19:14:59

by Hsin-Yi Wang

[permalink] [raw]
Subject: [PATCH v4 2/7] dt-bindings: arm64: mediatek: Add mt8183-kukui-katsu

Add katsu sku32 and sku38 which uses different audio codec.

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index a5999b3afc35..4fe58cfe6f1b 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -235,6 +235,13 @@ properties:
items:
- const: google,kappa
- const: mediatek,mt8183
+ - description: Google Katsu (ASUS Chromebook Detachable CZ1)
+ items:
+ - enum:
+ - google,katsu-sku32
+ - google,katsu-sku38
+ - const: google,katsu
+ - const: mediatek,mt8183
- description: Google Kodama (Lenovo 10e Chromebook Tablet)
items:
- enum:
--
2.42.0.820.g83a721a137-goog

2023-10-26 19:15:16

by Hsin-Yi Wang

[permalink] [raw]
Subject: [PATCH v4 4/7] dt-bindings: arm64: mediatek: Add mt8183-kukui-jacuzzi-makomo

Add makomo sku0 and sku1 which uses different audio codec.

Signed-off-by: Hsin-Yi Wang <[email protected]>
---
v3->v4: remove error const.
---
Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index 4fe58cfe6f1b..c937f49ba3b4 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -251,6 +251,13 @@ properties:
- google,kodama-sku32
- const: google,kodama
- const: mediatek,mt8183
+ - description: Google Makomo (Lenovo 100e Chromebook 2nd Gen MTK 2)
+ items:
+ - enum:
+ - google,makomo-sku0
+ - google,makomo-sku1
+ - const: google,makomo
+ - const: mediatek,mt8183
- description: Google Willow (Acer Chromebook 311 C722/C722T)
items:
- enum:
--
2.42.0.820.g83a721a137-goog

Subject: Re: [PATCH v4 2/7] dt-bindings: arm64: mediatek: Add mt8183-kukui-katsu

Il 26/10/23 21:09, Hsin-Yi Wang ha scritto:
> Add katsu sku32 and sku38 which uses different audio codec.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

Subject: Re: [PATCH v4 4/7] dt-bindings: arm64: mediatek: Add mt8183-kukui-jacuzzi-makomo

Il 26/10/23 21:09, Hsin-Yi Wang ha scritto:
> Add makomo sku0 and sku1 which uses different audio codec.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2023-10-27 11:17:57

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 0/7] Add a few mt8183 follower boards.

On 26/10/2023 21:09, Hsin-Yi Wang wrote:
> Add makomo, pico, and katsu which are mt8183 followers.
>
> v4: based on https://lore.kernel.org/all/[email protected]/
>

Where is the changelog? It's already v4 and still no changelog...

Best regards,
Krzysztof

2023-10-27 21:23:06

by Hsin-Yi Wang

[permalink] [raw]
Subject: Re: [PATCH v4 0/7] Add a few mt8183 follower boards.

On Fri, Oct 27, 2023 at 4:17 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 26/10/2023 21:09, Hsin-Yi Wang wrote:
> > Add makomo, pico, and katsu which are mt8183 followers.
> >
> > v4: based on https://lore.kernel.org/all/[email protected]/
> >
>
> Where is the changelog? It's already v4 and still no changelog...
>

v3:https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
v2:https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
v1:https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/

changelog with previous version are in each of the patchset. eg:
https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/

> Best regards,
> Krzysztof
>

2023-10-27 21:29:05

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v4 4/7] dt-bindings: arm64: mediatek: Add mt8183-kukui-jacuzzi-makomo


On Thu, 26 Oct 2023 12:09:13 -0700, Hsin-Yi Wang wrote:
> Add makomo sku0 and sku1 which uses different audio codec.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> v3->v4: remove error const.
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2023-10-28 07:58:21

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 0/7] Add a few mt8183 follower boards.

On 27/10/2023 23:22, Hsin-Yi Wang wrote:
> On Fri, Oct 27, 2023 at 4:17 AM Krzysztof Kozlowski
> <[email protected]> wrote:
>>
>> On 26/10/2023 21:09, Hsin-Yi Wang wrote:
>>> Add makomo, pico, and katsu which are mt8183 followers.
>>>
>>> v4: based on https://lore.kernel.org/all/[email protected]/
>>>
>>
>> Where is the changelog? It's already v4 and still no changelog...
>>
>
> v3:https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
> v2:https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
> v1:https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
>
> changelog with previous version are in each of the patchset. eg:
> https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/

One would think but:
https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/

Usually expected is in such case to wrote "v4: No changes".

Best regards,
Krzysztof

2023-10-30 07:32:54

by Hsin-Yi Wang

[permalink] [raw]
Subject: Re: [PATCH v4 0/7] Add a few mt8183 follower boards.

On Sat, Oct 28, 2023 at 12:58 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> On 27/10/2023 23:22, Hsin-Yi Wang wrote:
> > On Fri, Oct 27, 2023 at 4:17 AM Krzysztof Kozlowski
> > <[email protected]> wrote:
> >>
> >> On 26/10/2023 21:09, Hsin-Yi Wang wrote:
> >>> Add makomo, pico, and katsu which are mt8183 followers.
> >>>
> >>> v4: based on https://lore.kernel.org/all/[email protected]/
> >>>
> >>
> >> Where is the changelog? It's already v4 and still no changelog...
> >>
> >
> > v3:https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
> > v2:https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
> > v1:https://patchwork.kernel.org/project/linux-mediatek/cover/[email protected]/
> >
> > changelog with previous version are in each of the patchset. eg:
> > https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
>
> One would think but:
> https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
> https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
>
> Usually expected is in such case to wrote "v4: No changes".

Got it. Would add this notice next time. Thanks!

>
> Best regards,
> Krzysztof
>

2023-10-30 15:46:48

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v4 2/7] dt-bindings: arm64: mediatek: Add mt8183-kukui-katsu


On Thu, 26 Oct 2023 12:09:11 -0700, Hsin-Yi Wang wrote:
> Add katsu sku32 and sku38 which uses different audio codec.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/mediatek.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>

Acked-by: Rob Herring <[email protected]>