2023-10-27 06:19:08

by Nitin Yadav

Subject: [PATCH v2] arm64: boot: dts: ti: k3-am62a-main: Fix GPIO pin count in DT nodes.

Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according
to AM62A SK datasheet[0].

[0]https://www.ti.com/lit/gpn/am62a3 Section: 6.3.10 GPIO (Page No. 52-55)

Fixes: 5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")
Signed-off-by: Nitin Yadav <[email protected]>
---

v2:
- Updated commit msge to include links.
- Updated fixes tag

v1: https://lore.kernel.org/all/[email protected]/
arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
index 3198af08fb9f..de36abb243f1 100644
--- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
@@ -462,7 +462,7 @@ main_gpio0: gpio@600000 {
<193>, <194>, <195>;
interrupt-controller;
#interrupt-cells = <2>;
- ti,ngpio = <87>;
+ ti,ngpio = <92>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 77 TI_SCI_PD_EXCLUSIVE>;
clocks = <&k3_clks 77 0>;
@@ -480,7 +480,7 @@ main_gpio1: gpio@601000 {
<183>, <184>, <185>;
interrupt-controller;
#interrupt-cells = <2>;
- ti,ngpio = <88>;
+ ti,ngpio = <52>;
ti,davinci-gpio-unbanked = <0>;
power-domains = <&k3_pds 78 TI_SCI_PD_EXCLUSIVE>;
clocks = <&k3_clks 78 0>;
--
2.25.1

2023-10-27 06:49:44

by Nishanth Menon

Subject: Re: [PATCH v2] arm64: boot: dts: ti: k3-am62a-main: Fix GPIO pin count in DT nodes.

On 11:48-20231027, Nitin Yadav wrote:
> Fix number of gpio pins in main_gpio0 & main_gpio1 DT nodes according
> to AM62A SK datasheet[0].

Looks like you didn't get the hint from my review comment in v1.. so
here goes:

AM62A is a SoC and AM62A SK is a board. datasheet is for AM62A. Drop the "SK"

btw, Use AM62A7 as it the specific device (as used in the buggy
commit).

>
> [0]https://www.ti.com/lit/gpn/am62a3 Section: 6.3.10 GPIO (Page No. 52-55)
>
> Fixes: 5fc6b1b62639c ("arm64: dts: ti: Introduce AM62A7 family of SoCs")
> Signed-off-by: Nitin Yadav <[email protected]>
> ---
>
> v2:
> - Updated commit msge to include links.
> - Updated fixes tag
>
> v1: https://lore.kernel.org/all/[email protected]/
> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> index 3198af08fb9f..de36abb243f1 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-main.dtsi
> @@ -462,7 +462,7 @@ main_gpio0: gpio@600000 {
> <193>, <194>, <195>;
> interrupt-controller;
> #interrupt-cells = <2>;
> - ti,ngpio = <87>;
> + ti,ngpio = <92>;
> ti,davinci-gpio-unbanked = <0>;
> power-domains = <&k3_pds 77 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 77 0>;
> @@ -480,7 +480,7 @@ main_gpio1: gpio@601000 {
> <183>, <184>, <185>;
> interrupt-controller;
> #interrupt-cells = <2>;
> - ti,ngpio = <88>;
> + ti,ngpio = <52>;
> ti,davinci-gpio-unbanked = <0>;
> power-domains = <&k3_pds 78 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 78 0>;
> --
> 2.25.1
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D