2023-10-27 14:17:06

by VAMSHI GAJJELA

[permalink] [raw]
Subject: [PATCH v4 3/3] serial: core: Update uart_poll_timeout() function to return unsigned long

The function uart_fifo_timeout() returns an unsigned long value, which
is the number of jiffies. Therefore, change the variable timeout in the
function uart_poll_timeout() from int to unsigned long.
Change the return type of the function uart_poll_timeout() from int to
unsigned long to be consistent with the type of timeout values.

Signed-off-by: Vamshi Gajjela <[email protected]>
---
v4:
- author name in capitals to lowercase
v3:
- updated description
v2:
- unsigned long instead of unsigned int
- added () after function name in short log
- updated description

include/linux/serial_core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index bb6f073bc159..6916a1d7e477 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -773,9 +773,9 @@ static inline unsigned long uart_fifo_timeout(struct uart_port *port)
}

/* Base timer interval for polling */
-static inline int uart_poll_timeout(struct uart_port *port)
+static inline unsigned long uart_poll_timeout(struct uart_port *port)
{
- int timeout = uart_fifo_timeout(port);
+ unsigned long timeout = uart_fifo_timeout(port);

return timeout > 6 ? (timeout / 2 - 2) : 1;
}
--
2.42.0.820.g83a721a137-goog


2023-10-27 14:56:59

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] serial: core: Update uart_poll_timeout() function to return unsigned long

On Fri, Oct 27, 2023 at 07:45:34PM +0530, Vamshi Gajjela wrote:
> The function uart_fifo_timeout() returns an unsigned long value, which
> is the number of jiffies. Therefore, change the variable timeout in the
> function uart_poll_timeout() from int to unsigned long.
> Change the return type of the function uart_poll_timeout() from int to
> unsigned long to be consistent with the type of timeout values.
>
> Signed-off-by: Vamshi Gajjela <[email protected]>
> ---

Again, I can't do anything with just a 3/3 patch.

Please send whole series of commits. Again, what would you want to do
if you got 1000+ emails a day to do something with?

thanks,

greg k-h