2023-02-12 21:17:59

by Joe Perches

Subject: [PATCH RESEND] get_maintainer: add email addresses from dts files

From: Shawn Guo <[email protected]>

MAINTAINER file will get bloated quickly if individual section entry
is created for each .dts/.dtsi file. Add the email address from dts
files to get_maintainer output for saving unnecessary patching on
MAINTAINER file.

Suggested-by: Joe Perches <[email protected]>
Signed-off-by: Shawn Guo <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Joe Perches <[email protected]>
---

Hey Andrew. This was originally sent a year and a half ago.

Link: https://lore.kernel.org/all/[email protected]/

Please pick this up. Thanks.

scripts/get_maintainer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 2075db0c08b8..15aa8f947f4b 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -436,7 +436,7 @@ sub maintainers_in_file {

return if ($file =~ m@\bMAINTAINERS$@);

- if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
+ if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
open(my $f, '<', $file)
or die "$P: Can't open $file: $!\n";
my $text = do { local($/) ; <$f> };

2023-10-28 17:52:51

by Tom Rini

Subject: Re: [PATCH RESEND] get_maintainer: add email addresses from dts files

On Sun, Feb 12, 2023 at 01:17:45PM -0800, Joe Perches wrote:

> From: Shawn Guo <[email protected]>
>
> MAINTAINER file will get bloated quickly if individual section entry
> is created for each .dts/.dtsi file. Add the email address from dts
> files to get_maintainer output for saving unnecessary patching on
> MAINTAINER file.
>
> Suggested-by: Joe Perches <[email protected]>
> Signed-off-by: Shawn Guo <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> Acked-by: Joe Perches <[email protected]>
> ---
>
> Hey Andrew. This was originally sent a year and a half ago.
>
> Link: https://lore.kernel.org/all/[email protected]/
>
> Please pick this up. Thanks.
>
> scripts/get_maintainer.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 2075db0c08b8..15aa8f947f4b 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -436,7 +436,7 @@ sub maintainers_in_file {
>
> return if ($file =~ m@\bMAINTAINERS$@);
>
> - if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
> + if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
> open(my $f, '<', $file)
> or die "$P: Can't open $file: $!\n";
> my $text = do { local($/) ; <$f> };
>

This seems to have not been picked up, and would be useful for the tool
to have both for the kernel itself and other projects which also use it
and MAINTAINERS files. Can this please be picked up? Thanks!

--
Tom

2023-11-06 18:22:19

by Andrew Morton

Subject: Re: [PATCH RESEND] get_maintainer: add email addresses from dts files

On Sat, 28 Oct 2023 13:46:56 -0400 Tom Rini <[email protected]> wrote:

> > - if (-f $file && ($email_file_emails || $file =~ /\.yaml$/)) {
> > + if (-f $file && ($email_file_emails || $file =~ /\.(?:yaml|dtsi?)$/)) {
> > open(my $f, '<', $file)
> > or die "$P: Can't open $file: $!\n";
> > my $text = do { local($/) ; <$f> };
> >
>
> This seems to have not been picked up, and would be useful for the tool
> to have both for the kernel itself and other projects which also use it
> and MAINTAINERS files. Can this please be picked up? Thanks!

I'm not finding the original in my archives. Can we have a resend please?