2023-10-31 18:28:48

by Elliot Berman

Subject: [PATCH] dt-bindings: power: reset: $ref reboot-mode in nvmem-reboot-mode

nvmem-reboot-mode.yaml should $ref: reboot-mode.yaml, but instead
rewrites the properties. Update so it $refs instead.

Signed-off-by: Elliot Berman <[email protected]>
---
.../devicetree/bindings/power/reset/nvmem-reboot-mode.yaml | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
index 14a262bcbf7c..627f8a6078c2 100644
--- a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
+++ b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
@@ -28,17 +28,15 @@ properties:
items:
- const: reboot-mode

-patternProperties:
- "^mode-.+":
- $ref: /schemas/types.yaml#/definitions/uint32
- description: Vendor-specific mode value written to the mode register
+allOf:
+ - $ref: reboot-mode.yaml#

required:
- compatible
- nvmem-cells
- nvmem-cell-names

-additionalProperties: false
+unevaluatedProperties: false

examples:
- |

---
base-commit: ffc253263a1375a65fa6c9f62a893e9767fbebfa
change-id: 20231031-ref-nvmem-reboot-mode-1369970436e4

Best regards,
--
Elliot Berman <[email protected]>

2023-11-01 15:25:21

by Rob Herring

Subject: Re: [PATCH] dt-bindings: power: reset: $ref reboot-mode in nvmem-reboot-mode

On Tue, 31 Oct 2023 11:28:22 -0700, Elliot Berman wrote:
> nvmem-reboot-mode.yaml should $ref: reboot-mode.yaml, but instead
> rewrites the properties. Update so it $refs instead.
>
> Signed-off-by: Elliot Berman <[email protected]>
> ---
> .../devicetree/bindings/power/reset/nvmem-reboot-mode.yaml | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2023-11-01 15:48:00

by Mukesh Ojha

Subject: Re: [PATCH] dt-bindings: power: reset: $ref reboot-mode in nvmem-reboot-mode

On 10/31/2023 11:58 PM, Elliot Berman wrote:
> nvmem-reboot-mode.yaml should $ref: reboot-mode.yaml, but instead
> rewrites the properties. Update so it $refs instead.
>
> Signed-off-by: Elliot Berman <[email protected]>

Reviewed-by: Mukesh Ojha <[email protected]>

-Mukesh

> ---
> .../devicetree/bindings/power/reset/nvmem-reboot-mode.yaml | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> index 14a262bcbf7c..627f8a6078c2 100644
> --- a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> @@ -28,17 +28,15 @@ properties:
> items:
> - const: reboot-mode
>
> -patternProperties:
> - "^mode-.+":
> - $ref: /schemas/types.yaml#/definitions/uint32
> - description: Vendor-specific mode value written to the mode register
> +allOf:
> + - $ref: reboot-mode.yaml#
>
> required:
> - compatible
> - nvmem-cells
> - nvmem-cell-names
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
>
> ---
> base-commit: ffc253263a1375a65fa6c9f62a893e9767fbebfa
> change-id: 20231031-ref-nvmem-reboot-mode-1369970436e4
>
> Best regards,

2023-11-16 00:39:12

by Sebastian Reichel

Subject: Re: [PATCH] dt-bindings: power: reset: $ref reboot-mode in nvmem-reboot-mode

On Tue, 31 Oct 2023 11:28:22 -0700, Elliot Berman wrote:
> nvmem-reboot-mode.yaml should $ref: reboot-mode.yaml, but instead
> rewrites the properties. Update so it $refs instead.
>
>

Applied, thanks!

[1/1] dt-bindings: power: reset: $ref reboot-mode in nvmem-reboot-mode
commit: 5739da3e16ad0ebe99c31cabe960856b53eaaabe

Best regards,
--
Sebastian Reichel <[email protected]>