2023-11-01 12:30:00

by Antoniu Miclaus

Subject: [PATCH v4 1/2] dt-bindings: rtc: max31335: add max31335 bindings

Document the Analog Devices MAX31335 device tree bindings.

Reviewed-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Antoniu Miclaus <[email protected]>
---
changes in v4:
- drop `aux-voltage-chargeable` since it comes with rtc.yaml
.../devicetree/bindings/rtc/adi,max31335.yaml | 62 +++++++++++++++++++
1 file changed, 62 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rtc/adi,max31335.yaml

diff --git a/Documentation/devicetree/bindings/rtc/adi,max31335.yaml b/Documentation/devicetree/bindings/rtc/adi,max31335.yaml
new file mode 100644
index 000000000000..34cc87b92c02
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/adi,max31335.yaml
@@ -0,0 +1,62 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/adi,max31335.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices MAX31335 RTC
+
+maintainers:
+ - Antoniu Miclaus <[email protected]>
+
+description:
+ Analog Devices MAX31335 I2C RTC ±2ppm Automotive Real-Time Clock with
+ Integrated MEMS Resonator.
+
+allOf:
+ - $ref: rtc.yaml#
+
+properties:
+ compatible:
+ const: adi,max31335
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ "#clock-cells":
+ description:
+ RTC can be used as a clock source through its clock output pin.
+ const: 0
+
+ trickle-resistor-ohms:
+ description:
+ Selected resistor for trickle charger. Should be specified if trickle
+ charger should be enabled.
+ enum: [3000, 6000, 11000]
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ rtc@68 {
+ compatible = "adi,max31335";
+ reg = <0x68>;
+ pinctrl-0 = <&rtc_nint_pins>;
+ interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
+ trickle-resistor-ohms = <6000>;
+ aux-voltage-chargeable =<1>;
+ };
+ };
+...
--
2.42.0

2023-11-01 15:12:02

by Krzysztof Kozlowski

Subject: Re: [PATCH v4 1/2] dt-bindings: rtc: max31335: add max31335 bindings

On 01/11/2023 10:48, Antoniu Miclaus wrote:
> Document the Analog Devices MAX31335 device tree bindings.
>

...

>;
> + #size-cells = <0>;
> +
> + rtc@68 {
> + compatible = "adi,max31335";
> + reg = <0x68>;
> + pinctrl-0 = <&rtc_nint_pins>;
> + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>;
> + trickle-resistor-ohms = <6000>;
> + aux-voltage-chargeable =<1>;

Missing space after '='.

Keep Reviewed-by tag.

Best regards,
Krzysztof