On Thu, Sep 07, 2023 at 11:30:33AM +0530, Krishna chaitanya chundru wrote:
> While scaling the interconnect clocks based on PCIe link speed, it is also
> mandatory to scale the power domain performance state so that the SoC can
> run under optimum power conditions.
Can you expand "OPP" somewhere so we know what it stands for? I'm
sure everybody knows except me :)
This commit log says something is mandatory; can you phrase it so it
says what the patch actually *does*? The subject is kind of a title,
and I think it's important for the log to make sense without the
subject, so it's OK if the log repeats part or all of the subject.
Bjorn
On 01-11-23, 17:17, Bjorn Helgaas wrote:
> Can you expand "OPP" somewhere so we know what it stands for? I'm
> sure everybody knows except me :)
It is "Operating Performance Points", defined here:
Documentation/power/opp.rst
--
viresh
On Thu, Nov 02, 2023 at 11:00:13AM +0530, Viresh Kumar wrote:
> On 01-11-23, 17:17, Bjorn Helgaas wrote:
> > Can you expand "OPP" somewhere so we know what it stands for? I'm
> > sure everybody knows except me :)
>
> It is "Operating Performance Points", defined here:
>
> Documentation/power/opp.rst
Thanks; I meant in the subject or commit log of the next revision, of
course.
On 02-11-23, 07:09, Bjorn Helgaas wrote:
> On Thu, Nov 02, 2023 at 11:00:13AM +0530, Viresh Kumar wrote:
> > On 01-11-23, 17:17, Bjorn Helgaas wrote:
> > > Can you expand "OPP" somewhere so we know what it stands for? I'm
> > > sure everybody knows except me :)
> >
> > It is "Operating Performance Points", defined here:
> >
> > Documentation/power/opp.rst
>
> Thanks; I meant in the subject or commit log of the next revision, of
> course.
Yeah, I understood that. Krishna shall do it in next version I believe.
--
viresh