From: Konrad Dybcio <[email protected]>
SM8450's PRNG does not require a core clock reference. Add a new
compatible with a qcom,prng-ee fallback and handle that.
Signed-off-by: Konrad Dybcio <[email protected]>
Acked-by: Conor Dooley <[email protected]>
Signed-off-by: Elliot Berman <[email protected]>
---
I noticed this patch got missed while running make dtbs_check. No
changes to this patch from the original version:
https://lore.kernel.org/all/[email protected]/
.../devicetree/bindings/crypto/qcom,prng.yaml | 24 +++++++++++++++----
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
index bb42f4588b40..36b0ebd9a44b 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,prng.yaml
@@ -11,9 +11,13 @@ maintainers:
properties:
compatible:
- enum:
- - qcom,prng # 8916 etc.
- - qcom,prng-ee # 8996 and later using EE
+ oneOf:
+ - enum:
+ - qcom,prng # 8916 etc.
+ - qcom,prng-ee # 8996 and later using EE
+ - items:
+ - const: qcom,sm8450-prng-ee
+ - const: qcom,prng-ee
reg:
maxItems: 1
@@ -28,8 +32,18 @@ properties:
required:
- compatible
- reg
- - clocks
- - clock-names
+
+allOf:
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: qcom,sm8450-prng-ee
+ then:
+ required:
+ - clocks
+ - clock-names
additionalProperties: false
--
2.41.0
On 06/11/2023 18:05, Elliot Berman wrote:
>
>
> On 11/5/2023 5:03 AM, Krzysztof Kozlowski wrote:
>> On 03/11/2023 23:52, Elliot Berman wrote:
>>> From: Konrad Dybcio <[email protected]>
>>>
>>> SM8450's PRNG does not require a core clock reference. Add a new
>>> compatible with a qcom,prng-ee fallback and handle that.
>>>
>>> Signed-off-by: Konrad Dybcio <[email protected]>
>>> Acked-by: Conor Dooley <[email protected]>
>>> Signed-off-by: Elliot Berman <[email protected]>
>>> ---
>>> I noticed this patch got missed while running make dtbs_check. No
>>> changes to this patch from the original version:
>>>
>>> https://lore.kernel.org/all/[email protected]/
>>>
>>
>> I don't understand why do you send this. This is not a correct patch,
>> was rejected. Different patch was already merged.
>
> I see that 6.6 has
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sm8450.dtsi?h=v6.6#n1741
>
> but bindings not updated:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/crypto/qcom,prng.yaml?h=v6.6
>
> I came up with similar-ish fix offline, then found Konrad had posted the patch when searching lore.
> I didn't find any other patch on lore.
>
> I think you rejected a proposal to drop "p" from "prng", but this patch
> doesn't do that and we stayed course with naming scheme.
Please start working on linux-next, not on the last kernel release.
Best regards,
Krzysztof