2023-11-05 10:10:22

by Thomas Weißschuh

Subject: [PATCH 1/6] tools/nolibc: error out on unsupported architecture

When an architecture is unsupported arch.h would silently continue.
This leads to a lot of followup errors because my_syscallX() is not
defined and the startup code is missing.

Avoid these confusing errors and fail the build early with a clear
error message and location.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
tools/include/nolibc/arch.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/include/nolibc/arch.h b/tools/include/nolibc/arch.h
index e276fb0680af..2f72ccac0378 100644
--- a/tools/include/nolibc/arch.h
+++ b/tools/include/nolibc/arch.h
@@ -33,6 +33,8 @@
#include "arch-s390.h"
#elif defined(__loongarch__)
#include "arch-loongarch.h"
+#else
+#error Unsupported Architecture
#endif

#endif /* _NOLIBC_ARCH_H */

--
2.42.1

2023-11-05 10:37:15

by Willy Tarreau

Subject: Re: [PATCH 1/6] tools/nolibc: error out on unsupported architecture

On Sun, Nov 05, 2023 at 11:09:55AM +0100, Thomas Wei?schuh wrote:
> When an architecture is unsupported arch.h would silently continue.
> This leads to a lot of followup errors because my_syscallX() is not
> defined and the startup code is missing.
>
> Avoid these confusing errors and fail the build early with a clear
> error message and location.

Oops, good catch!

Thanks,
Willy