2023-11-15 21:12:36

by William Kennington

Subject: [PATCH] pinctrl: npcm7xx: prevent glitch when setting the GPIO to output high

From: Tomer Maimon <[email protected]>

Enable GPIO output after setting the output value to prevent a glitch
when pinctrl driver sets gpio pin to output high and the pin is in
the default state (high->low->high).

Signed-off-by: Tomer Maimon <[email protected]>
Signed-off-by: William A. Kennington III <[email protected]>
---
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
index 1e658721aaba..62a46d824b46 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
@@ -1790,8 +1790,8 @@ static int npcm7xx_config_set_one(struct npcm7xx_pinctrl *npcm,
bank->direction_input(&bank->gc, pin % bank->gc.ngpio);
break;
case PIN_CONFIG_OUTPUT:
- iowrite32(gpio, bank->base + NPCM7XX_GP_N_OES);
bank->direction_output(&bank->gc, pin % bank->gc.ngpio, arg);
+ iowrite32(gpio, bank->base + NPCM7XX_GP_N_OES);
break;
case PIN_CONFIG_DRIVE_PUSH_PULL:
npcm_gpio_clr(&bank->gc, bank->base + NPCM7XX_GP_N_OTYP, gpio);
--
2.43.0.rc0.421.g78406f8d94-goog

2023-11-24 09:44:59

by Linus Walleij

Subject: Re: [PATCH] pinctrl: npcm7xx: prevent glitch when setting the GPIO to output high

On Wed, Nov 15, 2023 at 10:12 PM William A. Kennington III
<[email protected]> wrote:

> From: Tomer Maimon <[email protected]>
>
> Enable GPIO output after setting the output value to prevent a glitch
> when pinctrl driver sets gpio pin to output high and the pin is in
> the default state (high->low->high).
>
> Signed-off-by: Tomer Maimon <[email protected]>
> Signed-off-by: William A. Kennington III <[email protected]>

Patch applied!

Yours,
Linus Walleij