2023-11-15 22:44:37

by Rob Clark

Subject: [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device

From: Rob Clark <[email protected]>

The dpu devcore's are already associated with the dpu device. So we
should associate the gpu devcore's with the gpu device, for easier
classification.

Signed-off-by: Rob Clark <[email protected]>
---
drivers/gpu/drm/msm/msm_gpu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
index cfcb4317afdb..3fad5d58262f 100644
--- a/drivers/gpu/drm/msm/msm_gpu.c
+++ b/drivers/gpu/drm/msm/msm_gpu.c
@@ -292,8 +292,7 @@ static void msm_gpu_crashstate_capture(struct msm_gpu *gpu,
/* Set the active crash state to be dumped on failure */
gpu->crashstate = state;

- /* FIXME: Release the crashstate if this errors out? */
- dev_coredumpm(gpu->dev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL,
+ dev_coredumpm(&gpu->pdev->dev, THIS_MODULE, gpu, 0, GFP_KERNEL,
msm_gpu_devcoredump_read, msm_gpu_devcoredump_free);
}
#else
--
2.41.0

2023-11-15 22:59:05

by Abhinav Kumar

Subject: Re: [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device

On 11/15/2023 2:44 PM, Rob Clark wrote:
> From: Rob Clark <[email protected]>
>
> The dpu devcore's are already associated with the dpu device. So we
> should associate the gpu devcore's with the gpu device, for easier
> classification.
>
> Signed-off-by: Rob Clark <[email protected]>

Reviewed-by: Abhinav Kumar <[email protected]>

2023-11-16 22:02:05

by Dmitry Baryshkov

Subject: Re: [PATCH] drm/msm/gpu: Move gpu devcore's to gpu device

On Thu, 16 Nov 2023 at 00:58, Abhinav Kumar <[email protected]> wrote:
>
>
>
> On 11/15/2023 2:44 PM, Rob Clark wrote:
> > From: Rob Clark <[email protected]>
> >
> > The dpu devcore's are already associated with the dpu device. So we
> > should associate the gpu devcore's with the gpu device, for easier
> > classification.
> >
> > Signed-off-by: Rob Clark <[email protected]>
>
> Reviewed-by: Abhinav Kumar <[email protected]>

Reviewed-by: Dmitry Baryshkov <[email protected]>

--
With best wishes
Dmitry