2023-11-16 01:14:38

by Yujie Liu

[permalink] [raw]
Subject: drivers/hwtracing/intel_th/msu.c:60: warning: Function parameter or member 'msc' not described in 'msc_window'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c42d9eeef8e5ba9292eda36fd8e3c11f35ee065c
commit: ba82664c134ef7ab97808f09a3c5e894b0a4900d intel_th: Add Memory Storage Unit driver
config: x86_64-randconfig-x011-20230813 (https://download.01.org/0day-ci/archive/20231116/[email protected]/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231116/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/r/[email protected]/

All warnings (new ones prefixed by >>):

>> drivers/hwtracing/intel_th/msu.c:60: warning: Function parameter or member 'msc' not described in 'msc_window'
>> drivers/hwtracing/intel_th/msu.c:101: warning: bad line:
drivers/hwtracing/intel_th/msu.c:134: warning: Function parameter or member 'iter_mutex' not described in 'msc'
>> drivers/hwtracing/intel_th/msu.c:134: warning: Function parameter or member 'iter_list' not described in 'msc'
>> drivers/hwtracing/intel_th/msu.c:894: warning: Function parameter or member 'nr_pages' not described in 'msc_buffer_alloc'
>> drivers/hwtracing/intel_th/msu.c:894: warning: Function parameter or member 'nr_wins' not described in 'msc_buffer_alloc'
>> drivers/hwtracing/intel_th/msu.c:894: warning: Excess function parameter 'size' description in 'msc_buffer_alloc'


vim +60 drivers/hwtracing/intel_th/msu.c

ba82664c134ef7a Alexander Shishkin 2015-09-22 46
ba82664c134ef7a Alexander Shishkin 2015-09-22 47 /**
ba82664c134ef7a Alexander Shishkin 2015-09-22 48 * struct msc_window - multiblock mode window descriptor
ba82664c134ef7a Alexander Shishkin 2015-09-22 49 * @entry: window list linkage (msc::win_list)
ba82664c134ef7a Alexander Shishkin 2015-09-22 50 * @pgoff: page offset into the buffer that this window starts at
ba82664c134ef7a Alexander Shishkin 2015-09-22 51 * @nr_blocks: number of blocks (pages) in this window
ba82664c134ef7a Alexander Shishkin 2015-09-22 52 * @block: array of block descriptors
ba82664c134ef7a Alexander Shishkin 2015-09-22 53 */
ba82664c134ef7a Alexander Shishkin 2015-09-22 54 struct msc_window {
ba82664c134ef7a Alexander Shishkin 2015-09-22 55 struct list_head entry;
ba82664c134ef7a Alexander Shishkin 2015-09-22 56 unsigned long pgoff;
ba82664c134ef7a Alexander Shishkin 2015-09-22 57 unsigned int nr_blocks;
ba82664c134ef7a Alexander Shishkin 2015-09-22 58 struct msc *msc;
ba82664c134ef7a Alexander Shishkin 2015-09-22 59 struct msc_block block[0];
ba82664c134ef7a Alexander Shishkin 2015-09-22 @60 };
ba82664c134ef7a Alexander Shishkin 2015-09-22 61
ba82664c134ef7a Alexander Shishkin 2015-09-22 62 /**
ba82664c134ef7a Alexander Shishkin 2015-09-22 63 * struct msc_iter - iterator for msc buffer
ba82664c134ef7a Alexander Shishkin 2015-09-22 64 * @entry: msc::iter_list linkage
ba82664c134ef7a Alexander Shishkin 2015-09-22 65 * @msc: pointer to the MSC device
ba82664c134ef7a Alexander Shishkin 2015-09-22 66 * @start_win: oldest window
ba82664c134ef7a Alexander Shishkin 2015-09-22 67 * @win: current window
ba82664c134ef7a Alexander Shishkin 2015-09-22 68 * @offset: current logical offset into the buffer
ba82664c134ef7a Alexander Shishkin 2015-09-22 69 * @start_block: oldest block in the window
ba82664c134ef7a Alexander Shishkin 2015-09-22 70 * @block: block number in the window
ba82664c134ef7a Alexander Shishkin 2015-09-22 71 * @block_off: offset into current block
ba82664c134ef7a Alexander Shishkin 2015-09-22 72 * @wrap_count: block wrapping handling
ba82664c134ef7a Alexander Shishkin 2015-09-22 73 * @eof: end of buffer reached
ba82664c134ef7a Alexander Shishkin 2015-09-22 74 */
ba82664c134ef7a Alexander Shishkin 2015-09-22 75 struct msc_iter {
ba82664c134ef7a Alexander Shishkin 2015-09-22 76 struct list_head entry;
ba82664c134ef7a Alexander Shishkin 2015-09-22 77 struct msc *msc;
ba82664c134ef7a Alexander Shishkin 2015-09-22 78 struct msc_window *start_win;
ba82664c134ef7a Alexander Shishkin 2015-09-22 79 struct msc_window *win;
ba82664c134ef7a Alexander Shishkin 2015-09-22 80 unsigned long offset;
ba82664c134ef7a Alexander Shishkin 2015-09-22 81 int start_block;
ba82664c134ef7a Alexander Shishkin 2015-09-22 82 int block;
ba82664c134ef7a Alexander Shishkin 2015-09-22 83 unsigned int block_off;
ba82664c134ef7a Alexander Shishkin 2015-09-22 84 unsigned int wrap_count;
ba82664c134ef7a Alexander Shishkin 2015-09-22 85 unsigned int eof;
ba82664c134ef7a Alexander Shishkin 2015-09-22 86 };
ba82664c134ef7a Alexander Shishkin 2015-09-22 87
ba82664c134ef7a Alexander Shishkin 2015-09-22 88 /**
ba82664c134ef7a Alexander Shishkin 2015-09-22 89 * struct msc - MSC device representation
ba82664c134ef7a Alexander Shishkin 2015-09-22 90 * @reg_base: register window base address
ba82664c134ef7a Alexander Shishkin 2015-09-22 91 * @thdev: intel_th_device pointer
ba82664c134ef7a Alexander Shishkin 2015-09-22 92 * @win_list: list of windows in multiblock mode
ba82664c134ef7a Alexander Shishkin 2015-09-22 93 * @nr_pages: total number of pages allocated for this buffer
ba82664c134ef7a Alexander Shishkin 2015-09-22 94 * @single_sz: amount of data in single mode
ba82664c134ef7a Alexander Shishkin 2015-09-22 95 * @single_wrap: single mode wrap occurred
ba82664c134ef7a Alexander Shishkin 2015-09-22 96 * @base: buffer's base pointer
ba82664c134ef7a Alexander Shishkin 2015-09-22 97 * @base_addr: buffer's base address
ba82664c134ef7a Alexander Shishkin 2015-09-22 98 * @user_count: number of users of the buffer
ba82664c134ef7a Alexander Shishkin 2015-09-22 99 * @mmap_count: number of mappings
ba82664c134ef7a Alexander Shishkin 2015-09-22 100 * @buf_mutex: mutex to serialize access to buffer-related bits
ba82664c134ef7a Alexander Shishkin 2015-09-22 @101
ba82664c134ef7a Alexander Shishkin 2015-09-22 102 * @enabled: MSC is enabled
ba82664c134ef7a Alexander Shishkin 2015-09-22 103 * @wrap: wrapping is enabled
ba82664c134ef7a Alexander Shishkin 2015-09-22 104 * @mode: MSC operating mode
ba82664c134ef7a Alexander Shishkin 2015-09-22 105 * @burst_len: write burst length
ba82664c134ef7a Alexander Shishkin 2015-09-22 106 * @index: number of this MSC in the MSU
ba82664c134ef7a Alexander Shishkin 2015-09-22 107 */
ba82664c134ef7a Alexander Shishkin 2015-09-22 108 struct msc {
ba82664c134ef7a Alexander Shishkin 2015-09-22 109 void __iomem *reg_base;
ba82664c134ef7a Alexander Shishkin 2015-09-22 110 struct intel_th_device *thdev;
ba82664c134ef7a Alexander Shishkin 2015-09-22 111
ba82664c134ef7a Alexander Shishkin 2015-09-22 112 struct list_head win_list;
ba82664c134ef7a Alexander Shishkin 2015-09-22 113 unsigned long nr_pages;
ba82664c134ef7a Alexander Shishkin 2015-09-22 114 unsigned long single_sz;
ba82664c134ef7a Alexander Shishkin 2015-09-22 115 unsigned int single_wrap : 1;
ba82664c134ef7a Alexander Shishkin 2015-09-22 116 void *base;
ba82664c134ef7a Alexander Shishkin 2015-09-22 117 dma_addr_t base_addr;
ba82664c134ef7a Alexander Shishkin 2015-09-22 118
ba82664c134ef7a Alexander Shishkin 2015-09-22 119 /* <0: no buffer, 0: no users, >0: active users */
ba82664c134ef7a Alexander Shishkin 2015-09-22 120 atomic_t user_count;
ba82664c134ef7a Alexander Shishkin 2015-09-22 121
ba82664c134ef7a Alexander Shishkin 2015-09-22 122 atomic_t mmap_count;
ba82664c134ef7a Alexander Shishkin 2015-09-22 123 struct mutex buf_mutex;
ba82664c134ef7a Alexander Shishkin 2015-09-22 124
ba82664c134ef7a Alexander Shishkin 2015-09-22 125 struct mutex iter_mutex;
ba82664c134ef7a Alexander Shishkin 2015-09-22 126 struct list_head iter_list;
ba82664c134ef7a Alexander Shishkin 2015-09-22 127
ba82664c134ef7a Alexander Shishkin 2015-09-22 128 /* config */
ba82664c134ef7a Alexander Shishkin 2015-09-22 129 unsigned int enabled : 1,
ba82664c134ef7a Alexander Shishkin 2015-09-22 130 wrap : 1;
ba82664c134ef7a Alexander Shishkin 2015-09-22 131 unsigned int mode;
ba82664c134ef7a Alexander Shishkin 2015-09-22 132 unsigned int burst_len;
ba82664c134ef7a Alexander Shishkin 2015-09-22 133 unsigned int index;
ba82664c134ef7a Alexander Shishkin 2015-09-22 @134 };
ba82664c134ef7a Alexander Shishkin 2015-09-22 135

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki