2023-11-15 15:50:53

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 3/3] EDAC, pnd2: Sort headers alphabetically

Sort the headers in alphabetic order in order to ease
the maintenance for this part.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/edac/pnd2_edac.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 676e02c8dc43..1bbedd59e36b 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -16,19 +16,20 @@
* rank, bank, row and column using the appropriate "dunit_ops" functions/parameters.
*/

-#include <linux/module.h>
-#include <linux/init.h>
-#include <linux/pci.h>
-#include <linux/pci_ids.h>
-#include <linux/slab.h>
+#include <linux/bitmap.h>
#include <linux/delay.h>
#include <linux/edac.h>
-#include <linux/mmzone.h>
-#include <linux/sizes.h>
-#include <linux/smp.h>
-#include <linux/bitmap.h>
+#include <linux/init.h>
#include <linux/math64.h>
+#include <linux/mmzone.h>
#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/pci.h>
+#include <linux/pci_ids.h>
+#include <linux/sizes.h>
+#include <linux/slab.h>
+#include <linux/smp.h>
+
#include <linux/platform_data/x86/p2sb.h>

#include <asm/cpu_device_id.h>
--
2.43.0.rc1.1.gbec44491f096


2023-11-16 08:33:00

by Qiuxu Zhuo

[permalink] [raw]
Subject: [PATCH v1 3/3] EDAC, pnd2: Sort headers alphabetically

> From: Andy Shevchenko <[email protected]>
> ...
>
> Sort the headers in alphabetic order in order to ease
> the maintenance for this part.

This patch LGTM. Thanks!

Reviewed-by: Qiuxu Zhuo <[email protected]>

>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/edac/pnd2_edac.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
> index 676e02c8dc43..1bbedd59e36b 100644
> --- a/drivers/edac/pnd2_edac.c
> +++ b/drivers/edac/pnd2_edac.c
> @@ -16,19 +16,20 @@
> * rank, bank, row and column using the appropriate "dunit_ops" functions/parameters.
> */
>
> -#include <linux/module.h>
> -#include <linux/init.h>
> -#include <linux/pci.h>
> -#include <linux/pci_ids.h>
> -#include <linux/slab.h>
> +#include <linux/bitmap.h>
> #include <linux/delay.h>
> #include <linux/edac.h>
> -#include <linux/mmzone.h>
> -#include <linux/sizes.h>
> -#include <linux/smp.h>
> -#include <linux/bitmap.h>
> +#include <linux/init.h>
> #include <linux/math64.h>
> +#include <linux/mmzone.h>
> #include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/pci.h>
> +#include <linux/pci_ids.h>
> +#include <linux/sizes.h>
> +#include <linux/slab.h>
> +#include <linux/smp.h>
> +
> #include <linux/platform_data/x86/p2sb.h>
>
> #include <asm/cpu_device_id.h>