LinuxLists.cc - [PATCH [1/2]] iio: humidity: Add driver for ti HDC302x humidity sensors

2023-11-16 12:56:12

Subject: [PATCH [1/2]] iio: humidity: Add driver for ti HDC302x humidity sensors

Add support for HDC302x integrated capacitive based relative
humidity (RH) and temperature sensor.
This driver supports reading values, reading the maximum and
minimum of values and controlling the integrated heater of
the sensor.

Signed-off-by: Li peiyu <[email protected]>
---
drivers/iio/humidity/Kconfig | 11 +
drivers/iio/humidity/Makefile | 1 +
drivers/iio/humidity/hdc3020.c | 481 +++++++++++++++++++++++++++++++++
3 files changed, 493 insertions(+)
create mode 100644 drivers/iio/humidity/hdc3020.c

diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
index 2de5494e7c22..7b585bc7db9a 100644
--- a/drivers/iio/humidity/Kconfig
+++ b/drivers/iio/humidity/Kconfig
@@ -48,6 +48,17 @@ config HDC2010
To compile this driver as a module, choose M here: the module
will be called hdc2010.

+config HDC3020
+ tristate "TI HDC3020 relative humidity and temperature sensor"
+ depends on I2C
+ help
+ Say yes here to build support for the Texas Instruments
+ HDC3020,HDC3021 and HDC3022 relative humidity and temperature
+ sensors.
+
+ To compile this driver as a module, choose M here: the module
+ will be called hdc3020.
+
config HID_SENSOR_HUMIDITY
tristate "HID Environmental humidity sensor"
depends on HID_SENSOR_HUB
diff --git a/drivers/iio/humidity/Makefile b/drivers/iio/humidity/Makefile
index f19ff3de97c5..5fbeef299f61 100644
--- a/drivers/iio/humidity/Makefile
+++ b/drivers/iio/humidity/Makefile
@@ -7,6 +7,7 @@ obj-$(CONFIG_AM2315) += am2315.o
obj-$(CONFIG_DHT11) += dht11.o
obj-$(CONFIG_HDC100X) += hdc100x.o
obj-$(CONFIG_HDC2010) += hdc2010.o
+obj-$(CONFIG_HDC3020) += hdc3020.o
obj-$(CONFIG_HID_SENSOR_HUMIDITY) += hid-sensor-humidity.o

hts221-y := hts221_core.o \
diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c
new file mode 100644
index 000000000000..a61f2358340f
--- /dev/null
+++ b/drivers/iio/humidity/hdc3020.c
@@ -0,0 +1,481 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * hdc3020.c - Support for the TI HDC3020,HDC3021 and HDC3022
+ * temperature + relative humidity sensors
+ *
+ * Copyright (C) 2023
+ *
+ * Datasheet: https://www.ti.com/lit/ds/symlink/hdc3020.pdf
+ */
+
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/i2c.h>
+#include <linux/bitops.h>
+#include <linux/delay.h>
+
+#include <linux/iio/iio.h>
+#include <linux/iio/sysfs.h>
+
+#define READ_RETRY_TIMES 10
+#define BUSY_DELAY 10
+
+const u8 HDC3020_S_AUTO_10HZ_MOD0[2] = { 0x27, 0x37 };
+
+const u8 HDC3020_EXIT_AUTO[2] = { 0x30, 0x93 };
+
+const u8 HDC3020_R_T_RH_AUTO[2] = { 0xE0, 0x00 };
+const u8 HDC3020_R_T_LOW_AUTO[2] = { 0xE0, 0x02 };
+const u8 HDC3020_R_T_HIGH_AUTO[2] = { 0xE0, 0x03 };
+const u8 HDC3020_R_RH_LOW_AUTO[2] = { 0xE0, 0x04 };
+const u8 HDC3020_R_RH_HIGH_AUTO[2] = { 0xE0, 0x05 };
+
+const u8 HDC3020_ENABLE_HEATER[2] = { 0x30, 0x6D };
+const u8 HDC3020_DISABLE_HEATER[2] = { 0x30, 0x66 };
+
+const u8 HDC3020_HEATER_FULL[5] = { 0x30, 0x6E, 0x3F, 0xFF, 0x06 };
+const u8 HDC3020_HEATER_HALF[5] = { 0x30, 0x6E, 0x03, 0xFF, 0x00 };
+const u8 HDC3020_HEATER_QUARTER[5] = { 0x30, 0x6E, 0x00, 0x9F, 0x96 };
+
+struct hdc3020_data {
+ struct i2c_client *client;
+ struct mutex lock;
+
+ int temp;
+ int humidity;
+ int temp_high_peak;
+ int temp_low_peak;
+ int humidity_high_peak;
+ int humidity_low_peak;
+};
+
+/*
+ * For heater
+ * 0 -> turn off
+ * 1 -> 1/4 full power
+ * 2 -> 1/2 full power
+ * 3 -> full power
+ */
+static IIO_CONST_ATTR(out_current_heater_raw_available, "0 1 2 3");
+
+static struct attribute *hdc3020_attributes[] = {
+ &iio_const_attr_out_current_heater_raw_available.dev_attr.attr,
+ NULL
+};
+
+static const struct attribute_group hdc3020_attribute_group = {
+ .attrs = hdc3020_attributes,
+};
+
+static const struct iio_chan_spec hdc3020_channels[] = {
+ {
+ .type = IIO_TEMP,
+ .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
+ BIT(IIO_CHAN_INFO_SCALE),
+ },
+ {
+ .type = IIO_TEMP,
+ .info_mask_separate = BIT(IIO_CHAN_INFO_PEAK),
+ .extend_name = "high",
+ },
+ {
+ .type = IIO_TEMP,
+ .info_mask_separate = BIT(IIO_CHAN_INFO_PEAK),
+ .extend_name = "low",
+ },
+ {
+ .type = IIO_HUMIDITYRELATIVE,
+ .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
+ BIT(IIO_CHAN_INFO_SCALE),
+ },
+ {
+ .type = IIO_HUMIDITYRELATIVE,
+ .info_mask_separate = BIT(IIO_CHAN_INFO_PEAK),
+ .extend_name = "high",
+ },
+ {
+ .type = IIO_HUMIDITYRELATIVE,
+ .info_mask_separate = BIT(IIO_CHAN_INFO_PEAK),
+ .extend_name = "low",
+ },
+ {
+ .type = IIO_CURRENT,
+ .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
+ .extend_name = "heater",
+ .output = 1,
+ },
+};
+
+static int hdc3020_write_bytes(struct hdc3020_data *data, const u8 *buf,
+ u8 len)
+{
+ int ret, cnt;
+ struct i2c_msg msg;
+ struct i2c_client *client = data->client;
+
+ msg.addr = client->addr;
+ msg.flags = 0;
+ msg.buf = (char *)buf;
+ msg.len = len;
+
+ /*
+ * During the measurement process, HDC3020 will not return data.
+ * So wait for a while and try again
+ */
+ ret = 0;
+ cnt = 0;
+
+ while (cnt < READ_RETRY_TIMES) {
+ ret = i2c_transfer(client->adapter, &msg, 1);
+ if (ret == 1) {
+ ret = 0;
+ break;
+ }
+
+ mdelay(BUSY_DELAY);
+ cnt++;
+ }
+ if (cnt == READ_RETRY_TIMES) {
+ dev_err(&client->dev, "Could not write sensor command\n");
+ ret = -EREMOTEIO;
+ }
+
+ return ret;
+}
+
+static int hdc3020_read_bytes(struct hdc3020_data *data, const u8 *buf,
+ void *val, int len)
+{
+ int ret, cnt;
+ struct i2c_msg msg[2];
+ struct i2c_client *client = data->client;
+
+ msg[0].addr = client->addr;
+ msg[0].flags = 0;
+ msg[0].buf = (char *)buf;
+ msg[0].len = 2;
+
+ msg[1].addr = client->addr;
+ msg[1].flags = I2C_M_RD;
+ msg[1].buf = val;
+ msg[1].len = len;
+
+ /*
+ * During the measurement process, HDC3020 will not return data.
+ * So wait for a while and try again
+ */
+ ret = 0;
+ cnt = 0;
+
+ while (cnt < READ_RETRY_TIMES) {
+ ret = i2c_transfer(client->adapter, msg, 2);
+ if (ret == 2) {
+ ret = 0;
+ break;
+ }
+ mdelay(BUSY_DELAY);
+ cnt++;
+ }
+
+ if (cnt == READ_RETRY_TIMES) {
+ dev_err(&client->dev, "Could not read sensor data\n");
+ ret = -EREMOTEIO;
+ }
+
+ return ret;
+}
+
+/*
+ * Returns temperature in DegC, resolution is 0.01 DegC. Output value of
+ * "2608" equals 26.08 DegC.
+ * Returns humidity in percent, resolution is 0.1 percent. Output value of
+ * "323" represents 323/10 = 32.3 %RH.
+ */
+static int hdc3020_read_measurement(struct hdc3020_data *data)
+{
+ int ret;
+ u8 buf[6];
+
+ ret = hdc3020_read_bytes(data, HDC3020_R_T_RH_AUTO, (void *)buf, 6);
+ if (ret < 0)
+ return ret;
+ data->temp = (((int)buf[0] << 8) | buf[1]) * 100 * 175 / 65535 - 4500;
+ data->humidity = (((int)buf[3] << 8) | buf[4]) * 10 * 100 / 65535;
+ return 0;
+}
+
+/*
+ * After exiting the automatic measurement mode or resetting, the peak
+ * value will be reset to the default value
+ */
+static int hdc3020_read_peak_temp(struct hdc3020_data *data)
+{
+ int ret;
+ u8 buf[3];
+
+ ret = hdc3020_read_bytes(data, HDC3020_R_T_LOW_AUTO, (void *)buf, 3);
+ if (ret < 0)
+ return ret;
+ data->temp_low_peak =
+ (((int)buf[0] << 8) | buf[1]) * 100 * 175 / 65535 - 4500;
+ ret = hdc3020_read_bytes(data, HDC3020_R_T_HIGH_AUTO, (void *)buf, 3);
+ if (ret < 0)
+ return ret;
+ data->temp_high_peak =
+ (((int)buf[0] << 8) | buf[1]) * 100 * 175 / 65535 - 4500;
+
+ return 0;
+}
+
+/*
+ * After exiting the automatic measurement mode or resetting, the peak
+ * value will be reset to the default value
+ */
+static int hdc3020_read_peak_humidity(struct hdc3020_data *data)
+{
+ int ret;
+ u8 buf[3];
+
+ ret = hdc3020_read_bytes(data, HDC3020_R_RH_LOW_AUTO, (void *)buf, 3);
+ if (ret < 0)
+ return ret;
+ data->humidity_low_peak =
+ (((int)buf[0] << 8) | buf[1]) * 10 * 100 / 65535;
+ ret = hdc3020_read_bytes(data, HDC3020_R_T_HIGH_AUTO, (void *)buf, 3);
+ if (ret < 0)
+ return ret;
+ data->humidity_high_peak =
+ (((int)buf[0] << 8) | buf[1]) * 10 * 100 / 65535;
+
+ return 0;
+}
+
+static int hdc3020_read_raw(struct iio_dev *indio_dev,
+ struct iio_chan_spec const *chan, int *val,
+ int *val2, long mask)
+{
+ struct hdc3020_data *data = iio_priv(indio_dev);
+
+ switch (mask) {
+ case IIO_CHAN_INFO_RAW:{
+ int ret;
+
+ ret = iio_device_claim_direct_mode(indio_dev);
+
+ if (ret)
+ return ret;
+
+ mutex_lock(&data->lock);
+ ret = hdc3020_read_measurement(data);
+ mutex_unlock(&data->lock);
+ iio_device_release_direct_mode(indio_dev);
+
+ if (ret < 0)
+ return ret;
+ if (chan->type == IIO_TEMP)
+ *val = data->temp;
+ else if (chan->type == IIO_HUMIDITYRELATIVE)
+ *val = data->humidity;
+ return IIO_VAL_INT;
+ }
+ case IIO_CHAN_INFO_PEAK:{
+ int ret;
+
+ ret = iio_device_claim_direct_mode(indio_dev);
+
+ if (ret)
+ return ret;
+
+ if (chan->type == IIO_TEMP) {
+ mutex_lock(&data->lock);
+ ret = hdc3020_read_peak_temp(data);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ if (strcmp(chan->extend_name, "high") == 0)
+ *val = data->temp_high_peak;
+ else if (strcmp(chan->extend_name, "low") == 0)
+ *val = data->temp_low_peak;
+ } else if (chan->type == IIO_HUMIDITYRELATIVE) {
+ mutex_lock(&data->lock);
+ ret = hdc3020_read_peak_humidity(data);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ if (strcmp(chan->extend_name, "high") == 0)
+ *val = data->humidity_high_peak;
+ else if (strcmp(chan->extend_name, "low") == 0)
+ *val = data->humidity_low_peak;
+ }
+ iio_device_release_direct_mode(indio_dev);
+ return IIO_VAL_INT;
+ }
+ case IIO_CHAN_INFO_SCALE:
+ *val2 = 65536;
+ if (chan->type == IIO_TEMP)
+ *val = 1750;
+ else
+ *val = 1000;
+ return IIO_VAL_FRACTIONAL;
+ default:
+ return -EINVAL;
+ }
+}
+
+static int hdc3020_write_raw(struct iio_dev *indio_dev,
+ struct iio_chan_spec const *chan,
+ int val, int val2, long mask)
+{
+ struct hdc3020_data *data = iio_priv(indio_dev);
+ int ret;
+
+ switch (mask) {
+ case IIO_CHAN_INFO_RAW:
+ if (chan->type != IIO_CURRENT || val2 != 0)
+ return -EINVAL;
+
+ switch (val) {
+ case 1:
+ mutex_lock(&data->lock);
+ ret =
+ hdc3020_write_bytes(data, HDC3020_HEATER_QUARTER,
+ 5);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ mutex_lock(&data->lock);
+ ret =
+ hdc3020_write_bytes(data, HDC3020_ENABLE_HEATER, 2);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ break;
+ case 2:
+ mutex_lock(&data->lock);
+ ret = hdc3020_write_bytes(data, HDC3020_HEATER_HALF, 5);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ mutex_lock(&data->lock);
+ ret =
+ hdc3020_write_bytes(data, HDC3020_ENABLE_HEATER, 2);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ break;
+ case 3:
+ mutex_lock(&data->lock);
+ ret = hdc3020_write_bytes(data, HDC3020_HEATER_FULL, 5);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ mutex_lock(&data->lock);
+ ret =
+ hdc3020_write_bytes(data, HDC3020_ENABLE_HEATER, 2);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ break;
+ case 0:
+ mutex_lock(&data->lock);
+ ret =
+ hdc3020_write_bytes(data, HDC3020_DISABLE_HEATER,
+ 2);
+ mutex_unlock(&data->lock);
+ if (ret < 0)
+ return ret;
+ break;
+ default:
+ return -EINVAL;
+ }
+ return ret;
+ default:
+ return -EINVAL;
+ }
+}
+
+static const struct iio_info hdc3020_info = {
+ .read_raw = hdc3020_read_raw,
+ .write_raw = hdc3020_write_raw,
+ .attrs = &hdc3020_attribute_group,
+};
+
+static int hdc3020_probe(struct i2c_client *client)
+{
+ struct iio_dev *indio_dev;
+ struct hdc3020_data *data;
+ int ret;
+
+ if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
+ return -EOPNOTSUPP;
+ indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
+ if (!indio_dev)
+ return -ENOMEM;
+ data = iio_priv(indio_dev);
+ i2c_set_clientdata(client, indio_dev);
+ data->client = client;
+ mutex_init(&data->lock);
+
+ indio_dev->name = "hdc3020";
+ indio_dev->modes = INDIO_DIRECT_MODE;
+ indio_dev->info = &hdc3020_info;
+
+ indio_dev->channels = hdc3020_channels;
+ indio_dev->num_channels = ARRAY_SIZE(hdc3020_channels);
+
+ ret = hdc3020_write_bytes(data, HDC3020_S_AUTO_10HZ_MOD0, 2);
+ if (ret) {
+ dev_err(&client->dev, "Unable to set up measurement\n");
+ return ret;
+ }
+
+ return iio_device_register(indio_dev);
+}
+
+static void hdc3020_remove(struct i2c_client *client)
+{
+ int ret;
+ struct iio_dev *indio_dev = i2c_get_clientdata(client);
+ struct hdc3020_data *data = iio_priv(indio_dev);
+
+ iio_device_unregister(indio_dev);
+
+ /* Disable Automatic Measurement Mode */
+ ret = hdc3020_write_bytes(data, HDC3020_EXIT_AUTO, 2);
+ if (ret)
+ dev_err(&client->dev, "Unable to stop measurement\n");
+}
+
+static const struct i2c_device_id hdc3020_id[] = {
+ { "hdc3020" },
+ { "hdc3021" },
+ { "hdc3022" },
+ { }
+};
+
+MODULE_DEVICE_TABLE(i2c, hdc3020_id);
+
+static const struct of_device_id hdc3020_dt_ids[] = {
+ {.compatible = "ti,hdc3020" },
+ {.compatible = "ti,hdc3021" },
+ {.compatible = "ti,hdc3022" },
+ { }
+};
+
+MODULE_DEVICE_TABLE(of, hdc3020_dt_ids);
+
+static struct i2c_driver hdc3020_driver = {
+ .driver = {
+ .name = "hdc3020",
+ .of_match_table = hdc3020_dt_ids,
+ },
+ .probe = hdc3020_probe,
+ .remove = hdc3020_remove,
+ .id_table = hdc3020_id,
+};
+
+module_i2c_driver(hdc3020_driver);
+
+MODULE_AUTHOR("Li peiyu <[email protected]>");
+MODULE_DESCRIPTION("TI HDC3020 humidity and temperature sensor driver");
+MODULE_LICENSE("GPL");
--
2.34.1

2023-11-16 12:58:24

by Li peiyu

[permalink] [raw]

Subject: [PATCH [1/2]] iio: humidity: Add driver for ti HDC302x humidity sensors

2023-11-16 13:14:55

by Li peiyu

[permalink] [raw]

Subject: [PATCH [2/2]] dt-bindings: iio: humidity: Add TI HDC302x support

Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and
temperature sensors.

Signed-off-by: Li peiyu <[email protected]>
---
.../bindings/iio/humidity/ti,hdc3020.yaml | 48 +++++++++++++++++++
1 file changed, 48 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml

diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
new file mode 100644
index 000000000000..8015c4bb5b2f
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors
+
+maintainers:
+ - Jonathan Cameron <[email protected]>
+
+description: |
+ The HDC302x is an integrated capacitive based relative humidity (RH)
+ and temperature sensor.
+
+ datasheet is available:
+ https://www.ti.com/lit/ds/symlink/hdc3020.pdf
+
+properties:
+ compatible:
+ enum:
+ - ti,hdc3020
+ - ti,hdc3021
+ - ti,hdc3022
+
+ interrupts:
+ maxItems: 1
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ humidity@47 {
+ compatible = "ti,hdc3020";
+ reg = <0x47>;
+ };
+ };
--
2.34.1

2023-11-16 13:31:54

by Li peiyu

[permalink] [raw]

Subject: Sorry,please ingore this email,this one is no is no different from the previous one.

I'm sorry that I used the wrong patch name when sending the email.
thanks,
Li peiyu.

>
> Add support for HDC302x integrated capacitive based relative
> humidity (RH) and temperature sensor.
> This driver supports reading values, reading the maximum and
> minimum of values and controlling the integrated heater of
> the sensor.
>
> Signed-off-by: Li peiyu <[email protected]>

2023-11-16 14:16:49

by Conor Dooley

[permalink] [raw]

Subject: Re: [PATCH [2/2]] dt-bindings: iio: humidity: Add TI HDC302x support

On Thu, Nov 16, 2023 at 09:14:07PM +0800, Li peiyu wrote:
> Add device tree bindings for HDC3020/HDC3021/HDC3022 humidity and
> temperature sensors.
>
> Signed-off-by: Li peiyu <[email protected]>
> ---
> .../bindings/iio/humidity/ti,hdc3020.yaml | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> new file mode 100644
> index 000000000000..8015c4bb5b2f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/humidity/ti,hdc3020.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HDC3020/HDC3021/HDC3022 humidity and temperature iio sensors
> +
> +maintainers:
> + - Jonathan Cameron <[email protected]>

Usually this is you, not the maintainer of the subsystem, since you have
the hardware in question and an interest in it specifically.

> +
> +description: |
> + The HDC302x is an integrated capacitive based relative humidity (RH)
> + and temperature sensor.
> +
> + datasheet is available:
> + https://www.ti.com/lit/ds/symlink/hdc3020.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - ti,hdc3020
> + - ti,hdc3021
> + - ti,hdc3022

Looking at your driver, all three of these seem to be compatible?
I did only have a quick look though, so please correct me if that is not
the case. If they are compatible, please set this up to use a fallback
compatible - for example allow
compatible = "ti,hdc3020";
compatible = "ti,hdc3021", "ti,hdc3020";
compatible = "ti,hdc3022", "ti,hdc3020";

> +
> + interrupts:
> + maxItems: 1
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + humidity@47 {

The generic node name here should probably be "humidity-sensor".

Cheers,
Conor.

> + compatible = "ti,hdc3020";
> + reg = <0x47>;
> + };
> + };
> --
> 2.34.1
>

Attachments:

(No filename) (2.38 kB)
signature.asc (235.00 B)
Download all attachments

2023-11-17 02:33:55

by kernel test robot

[permalink] [raw]

Subject: Re: [PATCH [1/2]] iio: humidity: Add driver for ti HDC302x humidity sensors

Hi Li,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.7-rc1 next-20231116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Li-peiyu/iio-humidity-Add-driver-for-ti-HDC302x-humidity-sensors/20231116-210050
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20231116125805.13466-1-579lpy%40gmail.com
patch subject: [PATCH [1/2]] iio: humidity: Add driver for ti HDC302x humidity sensors
config: x86_64-randconfig-r111-20231117 (https://download.01.org/0day-ci/archive/20231117/[email protected]/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231117/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

sparse warnings: (new ones prefixed by >>)
>> drivers/iio/humidity/hdc3020.c:23:10: sparse: sparse: symbol 'HDC3020_S_AUTO_10HZ_MOD0' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:25:10: sparse: sparse: symbol 'HDC3020_EXIT_AUTO' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:27:10: sparse: sparse: symbol 'HDC3020_R_T_RH_AUTO' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:28:10: sparse: sparse: symbol 'HDC3020_R_T_LOW_AUTO' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:29:10: sparse: sparse: symbol 'HDC3020_R_T_HIGH_AUTO' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:30:10: sparse: sparse: symbol 'HDC3020_R_RH_LOW_AUTO' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:31:10: sparse: sparse: symbol 'HDC3020_R_RH_HIGH_AUTO' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:33:10: sparse: sparse: symbol 'HDC3020_ENABLE_HEATER' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:34:10: sparse: sparse: symbol 'HDC3020_DISABLE_HEATER' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:36:10: sparse: sparse: symbol 'HDC3020_HEATER_FULL' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:37:10: sparse: sparse: symbol 'HDC3020_HEATER_HALF' was not declared. Should it be static?
>> drivers/iio/humidity/hdc3020.c:38:10: sparse: sparse: symbol 'HDC3020_HEATER_QUARTER' was not declared. Should it be static?

vim +/HDC3020_S_AUTO_10HZ_MOD0 +23 drivers/iio/humidity/hdc3020.c

22
> 23 const u8 HDC3020_S_AUTO_10HZ_MOD0[2] = { 0x27, 0x37 };
24
> 25 const u8 HDC3020_EXIT_AUTO[2] = { 0x30, 0x93 };
26
> 27 const u8 HDC3020_R_T_RH_AUTO[2] = { 0xE0, 0x00 };
> 28 const u8 HDC3020_R_T_LOW_AUTO[2] = { 0xE0, 0x02 };
> 29 const u8 HDC3020_R_T_HIGH_AUTO[2] = { 0xE0, 0x03 };
> 30 const u8 HDC3020_R_RH_LOW_AUTO[2] = { 0xE0, 0x04 };
> 31 const u8 HDC3020_R_RH_HIGH_AUTO[2] = { 0xE0, 0x05 };
32
> 33 const u8 HDC3020_ENABLE_HEATER[2] = { 0x30, 0x6D };
> 34 const u8 HDC3020_DISABLE_HEATER[2] = { 0x30, 0x66 };
35
> 36 const u8 HDC3020_HEATER_FULL[5] = { 0x30, 0x6E, 0x3F, 0xFF, 0x06 };
> 37 const u8 HDC3020_HEATER_HALF[5] = { 0x30, 0x6E, 0x03, 0xFF, 0x00 };
> 38 const u8 HDC3020_HEATER_QUARTER[5] = { 0x30, 0x6E, 0x00, 0x9F, 0x96 };
39

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki