2023-11-17 14:16:23

by Maciej Strozek

[permalink] [raw]
Subject: [PATCH 0/7] ASoC: cs43130: Fixes and improvements

This patchset aims to add minor fixes (first two patches) and
introduce general improvements to the driver (rest of the patches)

Maciej Strozek (7):
ASoC: cs43130: Fix the position of const qualifier
ASoC: cs43130: Fix incorrect frame delay configuration
ASoC: cs43130: Allow configuration of bit clock and frame inversion
ASoC: cs43130: Store device in private struct and use it more
consistently
ASoC: cs43130: Add handling of ACPI
ASoC: cs43130: Allow driver to work without IRQ thread
ASoC:cs43130: Add switch to control normal and alt hp inputs

sound/soc/codecs/cs43130.c | 311 ++++++++++++++++++++++++-------------
sound/soc/codecs/cs43130.h | 3 +
2 files changed, 204 insertions(+), 110 deletions(-)

--
2.34.1


2023-11-17 14:16:22

by Maciej Strozek

[permalink] [raw]
Subject: [PATCH 2/7] ASoC: cs43130: Fix incorrect frame delay configuration

Signed-off-by: Maciej Strozek <[email protected]>
---
sound/soc/codecs/cs43130.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c
index 20f06679b8f7..d8ec325b9cc9 100644
--- a/sound/soc/codecs/cs43130.c
+++ b/sound/soc/codecs/cs43130.c
@@ -578,7 +578,7 @@ static int cs43130_set_sp_fmt(int dai_id, unsigned int bitwidth_sclk,
break;
case SND_SOC_DAIFMT_LEFT_J:
hi_size = bitwidth_sclk;
- frm_delay = 2;
+ frm_delay = 0;
frm_phase = 1;
break;
case SND_SOC_DAIFMT_DSP_A:
--
2.34.1

2023-11-17 15:54:23

by Charles Keepax

[permalink] [raw]
Subject: Re: [PATCH 0/7] ASoC: cs43130: Fixes and improvements

On Fri, Nov 17, 2023 at 02:13:37PM +0000, Maciej Strozek wrote:
> This patchset aims to add minor fixes (first two patches) and
> introduce general improvements to the driver (rest of the patches)
>
> Maciej Strozek (7):
> ASoC: cs43130: Fix the position of const qualifier
> ASoC: cs43130: Fix incorrect frame delay configuration
> ASoC: cs43130: Allow configuration of bit clock and frame inversion
> ASoC: cs43130: Store device in private struct and use it more
> consistently
> ASoC: cs43130: Add handling of ACPI
> ASoC: cs43130: Allow driver to work without IRQ thread
> ASoC:cs43130: Add switch to control normal and alt hp inputs
>
> sound/soc/codecs/cs43130.c | 311 ++++++++++++++++++++++++-------------
> sound/soc/codecs/cs43130.h | 3 +
> 2 files changed, 204 insertions(+), 110 deletions(-)
>
> --

Series looks good to me:

Acked-by: Charles Keepax <[email protected]>

Thanks,
Charles

2023-11-18 00:33:24

by Mark Brown

[permalink] [raw]
Subject: Re: (subset) [PATCH 0/7] ASoC: cs43130: Fixes and improvements

On Fri, 17 Nov 2023 14:13:37 +0000, Maciej Strozek wrote:
> This patchset aims to add minor fixes (first two patches) and
> introduce general improvements to the driver (rest of the patches)
>
> Maciej Strozek (7):
> ASoC: cs43130: Fix the position of const qualifier
> ASoC: cs43130: Fix incorrect frame delay configuration
> ASoC: cs43130: Allow configuration of bit clock and frame inversion
> ASoC: cs43130: Store device in private struct and use it more
> consistently
> ASoC: cs43130: Add handling of ACPI
> ASoC: cs43130: Allow driver to work without IRQ thread
> ASoC:cs43130: Add switch to control normal and alt hp inputs
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/7] ASoC: cs43130: Fix the position of const qualifier
commit: e7f289a59e76a5890a57bc27b198f69f175f75d9
[2/7] ASoC: cs43130: Fix incorrect frame delay configuration
commit: aa7e8e5e4011571022dc06e4d7a2f108feb53d1a
[3/7] ASoC: cs43130: Allow configuration of bit clock and frame inversion
(no commit info)
[4/7] ASoC: cs43130: Store device in private struct and use it more consistently
commit: 552206add94dd7977bad32c37eba16e23756a0f9
[5/7] ASoC: cs43130: Add handling of ACPI
commit: ce7944b73e7729dc702b6741cff2b26886bb723c
[7/7] ASoC:cs43130: Add switch to control normal and alt hp inputs
commit: 9158221bf2aa5f7bfb916452c079b2fe63ca76e8

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark