2023-11-20 22:29:48

by Nico Pache

Subject: [PATCH] selftests/mm: prevent duplicate runs caused by TEST_GEN_PROGS

commit 05f1edac8009 ("selftests/mm: run all tests from run_vmtests.sh")
fixed the inconsistancy caused by tests being defined as TEST_GEN_PROGS.
This issue was leading to tests not being executed via run_vmtests.sh and
furthermore some tests running twice due to the kselftests wrapper also
executing them.

Fix the definition of two tests (soft-dirty and pagemap_ioctl)
that are still incorrectly defined.

Signed-off-by: Nico Pache <[email protected]>
---
tools/testing/selftests/mm/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
index 78dfec8bc676..dede0bcf97a3 100644
--- a/tools/testing/selftests/mm/Makefile
+++ b/tools/testing/selftests/mm/Makefile
@@ -60,7 +60,7 @@ TEST_GEN_FILES += mrelease_test
TEST_GEN_FILES += mremap_dontunmap
TEST_GEN_FILES += mremap_test
TEST_GEN_FILES += on-fault-limit
-TEST_GEN_PROGS += pagemap_ioctl
+TEST_GEN_FILES += pagemap_ioctl
TEST_GEN_FILES += thuge-gen
TEST_GEN_FILES += transhuge-stress
TEST_GEN_FILES += uffd-stress
@@ -72,7 +72,7 @@ TEST_GEN_FILES += mdwe_test
TEST_GEN_FILES += hugetlb_fault_after_madv

ifneq ($(ARCH),arm64)
-TEST_GEN_PROGS += soft-dirty
+TEST_GEN_FILES += soft-dirty
endif

ifeq ($(ARCH),x86_64)
--
2.41.0

2023-11-23 14:31:31

by David Hildenbrand

Subject: Re: [PATCH] selftests/mm: prevent duplicate runs caused by TEST_GEN_PROGS

On 20.11.23 23:29, Nico Pache wrote:
> commit 05f1edac8009 ("selftests/mm: run all tests from run_vmtests.sh")
> fixed the inconsistancy caused by tests being defined as TEST_GEN_PROGS.
> This issue was leading to tests not being executed via run_vmtests.sh and
> furthermore some tests running twice due to the kselftests wrapper also
> executing them.
>
> Fix the definition of two tests (soft-dirty and pagemap_ioctl)
> that are still incorrectly defined.
>
> Signed-off-by: Nico Pache <[email protected]>
> ---
> tools/testing/selftests/mm/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
> index 78dfec8bc676..dede0bcf97a3 100644
> --- a/tools/testing/selftests/mm/Makefile
> +++ b/tools/testing/selftests/mm/Makefile
> @@ -60,7 +60,7 @@ TEST_GEN_FILES += mrelease_test
> TEST_GEN_FILES += mremap_dontunmap
> TEST_GEN_FILES += mremap_test
> TEST_GEN_FILES += on-fault-limit
> -TEST_GEN_PROGS += pagemap_ioctl
> +TEST_GEN_FILES += pagemap_ioctl
> TEST_GEN_FILES += thuge-gen
> TEST_GEN_FILES += transhuge-stress
> TEST_GEN_FILES += uffd-stress
> @@ -72,7 +72,7 @@ TEST_GEN_FILES += mdwe_test
> TEST_GEN_FILES += hugetlb_fault_after_madv
>
> ifneq ($(ARCH),arm64)
> -TEST_GEN_PROGS += soft-dirty
> +TEST_GEN_FILES += soft-dirty
> endif
>
> ifeq ($(ARCH),x86_64)

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb