2023-11-21 09:24:48

by Jiri Slaby

[permalink] [raw]
Subject: [PATCH 05/17] tty: amiserial: return from receive_chars() without goto

The 'out' label is just before 'return'. So return immediately and drop
both the label and the return. This makes the code more straightforward.

Signed-off-by: Jiri Slaby (SUSE) <[email protected]>
---
drivers/tty/amiserial.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/tty/amiserial.c b/drivers/tty/amiserial.c
index 785558c65ae8..b9580bb9afd3 100644
--- a/drivers/tty/amiserial.c
+++ b/drivers/tty/amiserial.c
@@ -230,7 +230,7 @@ static void receive_chars(struct serial_state *info)
* should be ignored.
*/
if (status & info->ignore_status_mask)
- goto out;
+ return;

status &= info->read_status_mask;

@@ -258,8 +258,6 @@ static void receive_chars(struct serial_state *info)
if (oe == 1)
tty_insert_flip_char(&info->tport, 0, TTY_OVERRUN);
tty_flip_buffer_push(&info->tport);
-out:
- return;
}

static void transmit_chars(struct serial_state *info)
--
2.42.1