2023-11-21 11:16:52

by Asuna Yang

[permalink] [raw]
Subject: [PATCH] USB: serial: option: add Luat Air72*U series products

Update the USB serial option driver support for Luat Air72*U series
products.

ID 1782:4e00 Spreadtrum Communications Inc. UNISOC-8910

T: Bus=01 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 13 Spd=480 MxCh= 0
D: Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
P: Vendor=1782 ProdID=4e00 Rev=00.00
S: Manufacturer=UNISOC
S: Product=UNISOC-8910
C: #Ifs= 5 Cfg#= 1 Atr=e0 MxPwr=400mA
I: If#= 0 Alt= 0 #EPs= 1 Cls=e0(wlcon) Sub=01 Prot=03 Driver=rndis_host
E: Ad=82(I) Atr=03(Int.) MxPS= 8 Ivl=4096ms
I: If#= 1 Alt= 0 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=rndis_host
E: Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
E: Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I: If#= 3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
E: Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=84(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
I: If#= 4 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
E: Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
E: Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms

Co-developed-by: Yangyu Chen <[email protected]>
Signed-off-by: Yangyu Chen <[email protected]>
Signed-off-by: Sprite <[email protected]>
---
drivers/usb/serial/option.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index 45dcfaadaf98..b76cb9a096f7 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -609,6 +609,8 @@ static void option_instat_callback(struct urb *urb);
#define UNISOC_VENDOR_ID 0x1782
/* TOZED LT70-C based on UNISOC SL8563 uses UNISOC's vendor ID */
#define TOZED_PRODUCT_LT70C 0x4055
+/* Luat Air72*U series based on UNISOC UIS8910 uses UNISOC's vendor ID */
+#define LUAT_PRODUCT_AIR720U 0x4e00

/* Device flags */

@@ -2271,6 +2273,7 @@ static const struct usb_device_id option_ids[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0xff, 0x40) },
{ USB_DEVICE_AND_INTERFACE_INFO(SIERRA_VENDOR_ID, SIERRA_PRODUCT_EM9191, 0xff, 0, 0) },
{ USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, TOZED_PRODUCT_LT70C, 0xff, 0, 0) },
+ { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, LUAT_PRODUCT_AIR720U, 0xff, 0, 0) },
{ } /* Terminating entry */
};
MODULE_DEVICE_TABLE(usb, option_ids);
--
2.42.1


2023-11-21 11:25:58

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] USB: serial: option: add Luat Air72*U series products

> Co-developed-by: Yangyu Chen <[email protected]>
> Signed-off-by: Yangyu Chen <[email protected]>
> Signed-off-by: Sprite <[email protected]>

"Sprite" is an odd name, is that how things are signed by you?

thanks,

greg k-h

2023-11-21 12:02:54

by Asuna Yang

[permalink] [raw]
Subject: Re: [PATCH] USB: serial: option: add Luat Air72*U series products

I've been using that name for a long time in open source communities,
here's my GitHub profile:

https://github.com/SpriteOvO

Linux has allowed pseudonymous contributions since earlier this year,
does this apply to me? If you are concerned that "Sprite" will cause
confusion, I can use "Asuna", which is the name I used on IM chats and
social media platforms.

I apologize for the confusion.

On 11/21/23 19:25, Greg KH wrote:
>> Co-developed-by: Yangyu Chen <[email protected]>
>> Signed-off-by: Yangyu Chen <[email protected]>
>> Signed-off-by: Sprite <[email protected]>
> "Sprite" is an odd name, is that how things are signed by you?
>
> thanks,
>
> greg k-h

2023-11-21 14:49:48

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] USB: serial: option: add Luat Air72*U series products

On Tue, Nov 21, 2023 at 08:02:17PM +0800, SpriteOvO wrote:
> I've been using that name for a long time in open source communities, here's
> my GitHub profile:
>
> https://github.com/SpriteOvO
>
> Linux has allowed pseudonymous contributions since earlier this year, does
> this apply to me? If you are concerned that "Sprite" will cause confusion, I
> can use "Asuna", which is the name I used on IM chats and social media
> platforms.

A "unique" identifier that you use to identify yourself is fine,
"Sprite" is not really unique :)

thanks,

greg k-h