2023-11-23 17:08:32

by Philipp Zabel

Subject: [PATCH 1/3] drm/panel: ilitek-ili9881c: make use of prepare_prev_first

From: Marco Felsch <[email protected]>

The panel.prepare() call requires an initialized MIPI-DSI host, so set
the prepare_prev_first flag to indicate that the host must be
initialized first.

Signed-off-by: Marco Felsch <[email protected]>
Signed-off-by: Philipp Zabel <[email protected]>
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index 7838947a1bf3..0c911ed9141b 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -1094,6 +1094,8 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
return ret;
}

+ ctx->panel.prepare_prev_first = true;
+
ret = drm_panel_of_backlight(&ctx->panel);
if (ret)
return ret;

--
2.39.2

2023-12-05 08:13:41

by Neil Armstrong

Subject: Re: [PATCH 1/3] drm/panel: ilitek-ili9881c: make use of prepare_prev_first

On 23/11/2023 18:08, Philipp Zabel wrote:
> From: Marco Felsch <[email protected]>
>
> The panel.prepare() call requires an initialized MIPI-DSI host, so set
> the prepare_prev_first flag to indicate that the host must be
> initialized first.
>
> Signed-off-by: Marco Felsch <[email protected]>
> Signed-off-by: Philipp Zabel <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> index 7838947a1bf3..0c911ed9141b 100644
> --- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
> @@ -1094,6 +1094,8 @@ static int ili9881c_dsi_probe(struct mipi_dsi_device *dsi)
> return ret;
> }
>
> + ctx->panel.prepare_prev_first = true;
> +
> ret = drm_panel_of_backlight(&ctx->panel);
> if (ret)
> return ret;
>

Reviewed-by: Neil Armstrong <[email protected]>