2023-11-23 14:39:30

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v4 04/13] dt-bindings: riscv: Add Andes interrupt controller compatible string

On Wed, Nov 22, 2023 at 08:12:26PM +0800, Yu Chien Peter Lin wrote:
> Add "andestech,cpu-intc" compatible string to indicate that
> Andes specific local interrupt is supported on the core,
> e.g. AX45MP cores have 3 types of non-standard local interrupt
> can be handled in supervisor mode:
>
> - Slave port ECC error interrupt
> - Bus write transaction error interrupt
> - Performance monitor overflow interrupt
>
> These interrupts are enabled/disabled via a custom register
> SLIE instead of the standard interrupt enable register SIE.
>
> Signed-off-by: Yu Chien Peter Lin <[email protected]>

Acked-by: Conor Dooley <[email protected]>

Cheers,
Conor.

> ---
> Changes v1 -> v2:
> - New patch
> Changes v2 -> v3:
> - Updated commit message
> - Fixed possible compatibles for Andes INTC
> Changes v3 -> v4:
> - Add const entry instead of enum (Suggested by Conor)
> ---
> Documentation/devicetree/bindings/riscv/cpus.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/riscv/cpus.yaml b/Documentation/devicetree/bindings/riscv/cpus.yaml
> index f392e367d673..50307554478f 100644
> --- a/Documentation/devicetree/bindings/riscv/cpus.yaml
> +++ b/Documentation/devicetree/bindings/riscv/cpus.yaml
> @@ -100,7 +100,11 @@ properties:
> const: 1
>
> compatible:
> - const: riscv,cpu-intc
> + oneOf:
> + - items:
> + - const: andestech,cpu-intc
> + - const: riscv,cpu-intc
> + - const: riscv,cpu-intc
>
> interrupt-controller: true
>
> --
> 2.34.1
>


Attachments:
(No filename) (1.64 kB)
signature.asc (235.00 B)
Download all attachments