2023-11-22 23:11:03

by Rob Herring (Arm)

Subject: [RESEND PATCH v2] leds: syscon: Support 'reg' in addition to 'offset' for register address

The register-bit-led binding now also supports 'reg' in addition to
'offset' for the register address. Add support to the driver to get the
address from 'reg'.

Reviewed-by: Linus Walleij <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
---
The binding change landed, but v2[1] was never applied. The last
resend[2] may have missed kernel.org addresses.

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/

drivers/leds/leds-syscon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c
index 360a376fa738..d633ad519d0c 100644
--- a/drivers/leds/leds-syscon.c
+++ b/drivers/leds/leds-syscon.c
@@ -81,7 +81,8 @@ static int syscon_led_probe(struct platform_device *pdev)

sled->map = map;

- if (of_property_read_u32(np, "offset", &sled->offset))
+ if (of_property_read_u32(np, "reg", &sled->offset) &&
+ of_property_read_u32(np, "offset", &sled->offset))
return -EINVAL;
if (of_property_read_u32(np, "mask", &sled->mask))
return -EINVAL;
--
2.42.0

2023-11-23 09:13:15

by Lee Jones

Subject: Re: [RESEND PATCH v2] leds: syscon: Support 'reg' in addition to 'offset' for register address

On Wed, 22 Nov 2023, Rob Herring wrote:

> The register-bit-led binding now also supports 'reg' in addition to
> 'offset' for the register address. Add support to the driver to get the
> address from 'reg'.
>
> Reviewed-by: Linus Walleij <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> The binding change landed, but v2[1] was never applied. The last
> resend[2] may have missed kernel.org addresses.
>
> [1] https://lore.kernel.org/all/[email protected]/
> [2] https://lore.kernel.org/all/[email protected]/
>
> drivers/leds/leds-syscon.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Looks like I just applied the last one. I'm assuming no additional
changes, but please let me know if that's not the case.

--
Lee Jones [李琼斯]