2023-11-23 13:15:36

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] fixup! staging: vc04_services: bcm2835-isp: Add a more complex ISP processing component

On Mon, Nov 13, 2023 at 09:07:55AM -0500, Umang Jain wrote:
> Setup DMA Mask
> ---
> I realised while (re)creating the test branches (sent in reply to the cover
> letter), I missed to squash this hunk in
> "staging: vc04_services: bcm2835-isp: Add a more complex ISP processing component"
> before sending out the series.
>
> Sending it as a fixup! for now.

What does that mean? What can I do with this?

confused,

greg k-h


2023-11-23 13:53:59

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH] fixup! staging: vc04_services: bcm2835-isp: Add a more complex ISP processing component

On Thu, Nov 23, 2023 at 12:56:07PM +0000, Greg KH wrote:
> On Mon, Nov 13, 2023 at 09:07:55AM -0500, Umang Jain wrote:
> > Setup DMA Mask
> > ---
> > I realised while (re)creating the test branches (sent in reply to the cover
> > letter), I missed to squash this hunk in
> > "staging: vc04_services: bcm2835-isp: Add a more complex ISP processing component"
> > before sending out the series.
> >
> > Sending it as a fixup! for now.
>
> What does that mean? What can I do with this?

Umang, we don't do that for upstream kernel development. If a patch
needs a new version, you should send a new version. In some subsystems
maintainers will prefer if you only resubmit the offending patch when
the series is large (as a "vN.1" instead of a vN+1), while in other
cases resending the whole series is preferred.

Greg, I don't think Umang wanted you to do anything with this patch :-)
This was meant to tell reviewer that the issue was known already.

--
Regards,

Laurent Pinchart