2023-11-24 18:17:38

by Alex Elder

[permalink] [raw]
Subject: [PATCH 0/2] arm64: dts: qcom: enable IPA on sm8550

Add the basic DTS information for supporting IPA on the Qualcomm
SM8550 SoC. Enable IPA on the SM8550 QRD platform; GSI firmware is
loaded by the AP in this case.

-Alex

Alex Elder (2):
arm64: dts: qcom: sm8550: add IPA information
arm64: dts: qcom: sm8550-qrd: enable IPA

arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 7 +++++
arch/arm64/boot/dts/qcom/sm8550.dtsi | 39 +++++++++++++++++++++++++
2 files changed, 46 insertions(+)

--
2.34.1


2023-11-24 18:17:46

by Alex Elder

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: qcom: sm8550: add IPA information

Add IPA-related nodes and definitions to "sm8550.dtsi", which uses
IPA v5.5.

Signed-off-by: Alex Elder <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 39 ++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 7bafb3d88d69b..4d28150c985b5 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -1995,6 +1995,45 @@ gpucc: clock-controller@3d90000 {
#power-domain-cells = <1>;
};

+ ipa: ipa@3f40000 {
+ compatible = "qcom,sm8550-ipa";
+
+ iommus = <&apps_smmu 0x4a0 0x0>,
+ <&apps_smmu 0x4a2 0x0>;
+ reg = <0 0x3f40000 0 0x10000>,
+ <0 0x3f50000 0 0x5000>,
+ <0 0x3e04000 0 0xfc000>;
+ reg-names = "ipa-reg",
+ "ipa-shared",
+ "gsi";
+
+ interrupts-extended = <&intc GIC_SPI 654 IRQ_TYPE_EDGE_RISING>,
+ <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>,
+ <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>,
+ <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "ipa",
+ "gsi",
+ "ipa-clock-query",
+ "ipa-setup-ready";
+
+ clocks = <&rpmhcc RPMH_IPA_CLK>;
+ clock-names = "core";
+
+ interconnects = <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>,
+ <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>;
+ interconnect-names = "memory",
+ "config";
+
+ qcom,qmp = <&aoss_qmp>;
+
+ qcom,smem-states = <&ipa_smp2p_out 0>,
+ <&ipa_smp2p_out 1>;
+ qcom,smem-state-names = "ipa-clock-enabled-valid",
+ "ipa-clock-enabled";
+
+ status = "disabled";
+ };
+
remoteproc_mpss: remoteproc@4080000 {
compatible = "qcom,sm8550-mpss-pas";
reg = <0x0 0x04080000 0x0 0x4040>;
--
2.34.1

2023-11-24 18:17:53

by Alex Elder

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: qcom: sm8550-qrd: enable IPA

Enable IPA on the SM8550 QRD. The GSI firmware on this platform is
loaded by the AP.

Signed-off-by: Alex Elder <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
index eef811def39bc..34c760549f3ee 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
@@ -585,6 +585,13 @@ fsa4480_sbu_mux: endpoint {
};
};

+&ipa {
+ qcom,gsi-loader = "self";
+ memory-region = <&ipa_fw_mem>;
+ firmware-name = "qcom/sm8550/ipa_fws.mbn";
+ status = "okay";
+};
+
&gcc {
clocks = <&bi_tcxo_div2>, <&sleep_clk>,
<&pcie0_phy>,
--
2.34.1

2023-11-27 11:14:20

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: dts: qcom: enable IPA on sm8550

On 24/11/2023 19:17, Alex Elder wrote:
> Add the basic DTS information for supporting IPA on the Qualcomm
> SM8550 SoC. Enable IPA on the SM8550 QRD platform; GSI firmware is
> loaded by the AP in this case.
>
> -Alex
>
> Alex Elder (2):
> arm64: dts: qcom: sm8550: add IPA information
> arm64: dts: qcom: sm8550-qrd: enable IPA
>
> arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 7 +++++
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 39 +++++++++++++++++++++++++
> 2 files changed, 46 insertions(+)
>

Tested-by: Neil Armstrong <[email protected]> # on SM8550-QRD

Thanks,
Neil

2023-12-08 02:54:53

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 0/2] arm64: dts: qcom: enable IPA on sm8550


On Fri, 24 Nov 2023 12:17:16 -0600, Alex Elder wrote:
> Add the basic DTS information for supporting IPA on the Qualcomm
> SM8550 SoC. Enable IPA on the SM8550 QRD platform; GSI firmware is
> loaded by the AP in this case.
>
> -Alex
>
> Alex Elder (2):
> arm64: dts: qcom: sm8550: add IPA information
> arm64: dts: qcom: sm8550-qrd: enable IPA
>
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: sm8550: add IPA information
commit: 32c5a8b93ba543e3cc596b0272b5ed7fac82278c
[2/2] arm64: dts: qcom: sm8550-qrd: enable IPA
commit: 33eae059ccaf71f6243dd919add405dfefd275e7

Best regards,
--
Bjorn Andersson <[email protected]>