After looking into the latest changes in the driver I noticed one
wrong patch. That induced looking closer to the current state of
affairs in the driver. It appears that some code is outdated and
may be cleaned up. Hence this series.
Andy Shevchenko (5):
mfd: intel-lpss: Revert "Add missing check for platform_get_resource"
mfd: intel-lpss: Use device_get_match_data()
mfd: intel-lpss: Adjust header inclusions
mfd: intel-lpss: Move exported symbols to INTEL_LPSS namespace
mfd: intel-lpss: Provide Intel LPSS PM ops structure
drivers/mfd/intel-lpss-acpi.c | 27 ++++++++++++------------
drivers/mfd/intel-lpss-pci.c | 19 ++++++++++-------
drivers/mfd/intel-lpss.c | 39 +++++++++++++++++++++--------------
drivers/mfd/intel-lpss.h | 28 +------------------------
4 files changed, 51 insertions(+), 62 deletions(-)
--
2.43.0.rc1.1.gbec44491f096
Adjust header inclusions to avoid "proxy" headers and explicitly
include what we are using.
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/mfd/intel-lpss-acpi.c | 6 +++++-
drivers/mfd/intel-lpss-pci.c | 8 ++++++--
drivers/mfd/intel-lpss.c | 17 ++++++++++++-----
3 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c
index bba208235754..e4a62cc02cfc 100644
--- a/drivers/mfd/intel-lpss-acpi.c
+++ b/drivers/mfd/intel-lpss-acpi.c
@@ -8,15 +8,19 @@
* Mika Westerberg <[email protected]>
*/
+#include <linux/device.h>
+#include <linux/gfp_types.h>
#include <linux/ioport.h>
-#include <linux/kernel.h>
#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/pm_runtime.h>
#include <linux/platform_device.h>
#include <linux/property.h>
+
#include <linux/pxa2xx_ssp.h>
+#include <asm/errno.h>
+
#include "intel-lpss.h"
static const struct property_entry spt_spi_properties[] = {
diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 94042bfe7dbf..bc15379afe3b 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -8,14 +8,18 @@
* Mika Westerberg <[email protected]>
*/
-#include <linux/ioport.h>
-#include <linux/kernel.h>
+#include <linux/device.h>
+#include <linux/gfp_types.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/pci.h>
#include <linux/pm_runtime.h>
#include <linux/property.h>
+
#include <linux/pxa2xx_ssp.h>
+#include <asm/errno.h>
+
#include "intel-lpss.h"
/* Some DSDTs have an unused GEXP ACPI device conflicting with I2C4 resources */
diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index bbd65da46db6..79ea5e2ad0a6 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -10,26 +10,33 @@
* Jarkko Nikula <[email protected]>
*/
-#include <linux/clk.h>
+#include <linux/array_size.h>
+#include <linux/bits.h>
#include <linux/clkdev.h>
+#include <linux/clk.h>
#include <linux/clk-provider.h>
#include <linux/debugfs.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/gfp_types.h>
#include <linux/idr.h>
#include <linux/io.h>
#include <linux/ioport.h>
-#include <linux/kernel.h>
-#include <linux/module.h>
#include <linux/mfd/core.h>
+#include <linux/module.h>
#include <linux/pm_qos.h>
#include <linux/pm_runtime.h>
-#include <linux/property.h>
-#include <linux/seq_file.h>
+#include <linux/sprintf.h>
+#include <linux/types.h>
+
#include <linux/io-64-nonatomic-lo-hi.h>
#include <linux/dma/idma64.h>
#include "intel-lpss.h"
+struct dentry;
+
#define LPSS_DEV_OFFSET 0x000
#define LPSS_DEV_SIZE 0x200
#define LPSS_PRIV_OFFSET 0x200
--
2.43.0.rc1.1.gbec44491f096
On Fri, 24 Nov 2023 21:31:23 +0200, Andy Shevchenko wrote:
> After looking into the latest changes in the driver I noticed one
> wrong patch. That induced looking closer to the current state of
> affairs in the driver. It appears that some code is outdated and
> may be cleaned up. Hence this series.
>
> Andy Shevchenko (5):
> mfd: intel-lpss: Revert "Add missing check for platform_get_resource"
> mfd: intel-lpss: Use device_get_match_data()
> mfd: intel-lpss: Adjust header inclusions
> mfd: intel-lpss: Move exported symbols to INTEL_LPSS namespace
> mfd: intel-lpss: Provide Intel LPSS PM ops structure
>
> [...]
Applied, thanks!
[1/5] mfd: intel-lpss: Revert "Add missing check for platform_get_resource"
commit: ad85d36c6770f21d961f5e5e47dc25f56d50c96e
[2/5] mfd: intel-lpss: Use device_get_match_data()
commit: 403c475743959f787156fc2120c1e5c557f8357d
[3/5] mfd: intel-lpss: Adjust header inclusions
commit: 62b2a4b3fb4922cb5201ff3787efd84186b0699c
[4/5] mfd: intel-lpss: Move exported symbols to INTEL_LPSS namespace
commit: 2221afc08e16bf0cbc5234107cc5c9edb850e0bb
[5/5] mfd: intel-lpss: Provide Intel LPSS PM ops structure
commit: 41e15f246791772c312caa8662368191d5b7289a
--
Lee Jones [李琼斯]