2023-11-25 01:25:15

by David Regan

Subject: [PATCH v5 2/4] mtd: rawnand: NAND controller write protect

From: David Regan <[email protected]>

Allow NAND controller to be responsible for write protect pin
handling during fast path and exec_op destructive operation
when controller_wp flag is set.

Signed-off-by: David Regan <[email protected]>
---
Changes in v5: none

Changes in v4: none

Changes in v3: update comments

Changes in v2: none
---
drivers/mtd/nand/raw/nand_base.c | 4 ++++
include/linux/mtd/rawnand.h | 2 ++
2 files changed, 6 insertions(+)

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 47cc2c35153b..38ed0ced5b8e 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -367,6 +367,10 @@ static int nand_check_wp(struct nand_chip *chip)
if (chip->options & NAND_BROKEN_XD)
return 0;

+ /* controller responsible for NAND write protect */
+ if (chip->controller->controller_wp)
+ return 0;
+
/* Check the WP bit */
ret = nand_status_op(chip, &status);
if (ret)
diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
index 31aceda8616c..fcad94aa0515 100644
--- a/include/linux/mtd/rawnand.h
+++ b/include/linux/mtd/rawnand.h
@@ -1111,6 +1111,7 @@ struct nand_controller_ops {
* the bus without restarting an entire read operation nor
* changing the column.
* @supported_op.cont_read: The controller supports sequential cache reads.
+ * @controller_wp: the controller is in charge of handling the WP pin.
*/
struct nand_controller {
struct mutex lock;
@@ -1119,6 +1120,7 @@ struct nand_controller {
unsigned int data_only_read: 1;
unsigned int cont_read: 1;
} supported_op;
+ bool controller_wp;
};

static inline void nand_controller_init(struct nand_controller *nfc)
--
2.37.3

2023-11-25 17:24:05

by Florian Fainelli

Subject: Re: [PATCH v5 2/4] mtd: rawnand: NAND controller write protect

On 11/24/2023 5:24 PM, [email protected] wrote:
> From: David Regan <[email protected]>
>
> Allow NAND controller to be responsible for write protect pin
> handling during fast path and exec_op destructive operation
> when controller_wp flag is set.
>
> Signed-off-by: David Regan <[email protected]>

Reviewed-by: Florian Fainelli <[email protected]>
--
Florian

2023-11-30 10:37:02

by Miquel Raynal

Subject: Re: [PATCH v5 2/4] mtd: rawnand: NAND controller write protect

On Sat, 2023-11-25 at 01:24:36 UTC, [email protected] wrote:
> From: David Regan <[email protected]>
>
> Allow NAND controller to be responsible for write protect pin
> handling during fast path and exec_op destructive operation
> when controller_wp flag is set.
>
> Signed-off-by: David Regan <[email protected]>
> Reviewed-by: Florian Fainelli <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel