2023-11-22 07:59:01

by Lukas Bulwahn

Subject: [PATCH] MAINTAINERS: improve section MICROCHIP MCP3564 ADC DRIVER

Commit 33ec3e5fc1ea ("iio: adc: adding support for MCP3564 ADC") adds a new
iio driver and corresponding MAINTAINERS section. It however uses spaces
instead of a single tab for all the entries in that MAINTAINERS section.

Although, the get_maintainer.pl script handles spaces instead of tabs
silently, the MAINTAINERS will quickly get into a messy state with
different indentations throughout the file. So, the checkpatch.pl script
complains when spaces instead of a single tab are used.

Fix this recently added section using tabs instead of spaces.
Further, add the driver's ABI documentation file to this section as well.

Fixes: 33ec3e5fc1ea ("iio: adc: adding support for MCP3564 ADC")
Signed-off-by: Lukas Bulwahn <[email protected]>
---
MAINTAINERS | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 04c6fcbb21aa..c74ec0681aa1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14213,11 +14213,12 @@ F: Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
F: drivers/regulator/mcp16502.c

MICROCHIP MCP3564 ADC DRIVER
-M: Marius Cristea <[email protected]>
-L: [email protected]
-S: Supported
-F: Documentation/devicetree/bindings/iio/adc/microchip,mcp3564.yaml
-F: drivers/iio/adc/mcp3564.c
+M: Marius Cristea <[email protected]>
+L: [email protected]
+S: Supported
+F: Documentation/ABI/testing/sysfs-bus-iio-adc-mcp3564
+F: Documentation/devicetree/bindings/iio/adc/microchip,mcp3564.yaml
+F: drivers/iio/adc/mcp3564.c

MICROCHIP MCP3911 ADC DRIVER
M: Marcus Folkesson <[email protected]>
--
2.17.1

2023-11-25 17:23:58

by Jonathan Cameron

Subject: Re: [PATCH] MAINTAINERS: improve section MICROCHIP MCP3564 ADC DRIVER

On Wed, 22 Nov 2023 08:56:29 +0100
Lukas Bulwahn <[email protected]> wrote:

> Commit 33ec3e5fc1ea ("iio: adc: adding support for MCP3564 ADC") adds a new
> iio driver and corresponding MAINTAINERS section. It however uses spaces
> instead of a single tab for all the entries in that MAINTAINERS section.
>
> Although, the get_maintainer.pl script handles spaces instead of tabs
> silently, the MAINTAINERS will quickly get into a messy state with
> different indentations throughout the file. So, the checkpatch.pl script
> complains when spaces instead of a single tab are used.
>
> Fix this recently added section using tabs instead of spaces.
> Further, add the driver's ABI documentation file to this section as well.
>
> Fixes: 33ec3e5fc1ea ("iio: adc: adding support for MCP3564 ADC")
> Signed-off-by: Lukas Bulwahn <[email protected]>
Good to cleanup, but I'm guessing no super rush to do so and this can wait for
next merge window.

As such, applied to the togreg branch of iio.git and initially pushed out
as testing for 0-day to ignore this one.

Jonathan

> ---
> MAINTAINERS | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 04c6fcbb21aa..c74ec0681aa1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14213,11 +14213,12 @@ F: Documentation/devicetree/bindings/regulator/mcp16502-regulator.txt
> F: drivers/regulator/mcp16502.c
>
> MICROCHIP MCP3564 ADC DRIVER
> -M: Marius Cristea <[email protected]>
> -L: [email protected]
> -S: Supported
> -F: Documentation/devicetree/bindings/iio/adc/microchip,mcp3564.yaml
> -F: drivers/iio/adc/mcp3564.c
> +M: Marius Cristea <[email protected]>
> +L: [email protected]
> +S: Supported
> +F: Documentation/ABI/testing/sysfs-bus-iio-adc-mcp3564
> +F: Documentation/devicetree/bindings/iio/adc/microchip,mcp3564.yaml
> +F: drivers/iio/adc/mcp3564.c
>
> MICROCHIP MCP3911 ADC DRIVER
> M: Marcus Folkesson <[email protected]>