2023-11-27 15:36:44

by Roland Hieber

[permalink] [raw]

Subject: [PATCH] dt-bindings: mxsfb: Remove power-domains requirements for i.MX7D

---

From: Philipp Zabel <[email protected]>

i.MX7D is documented as compatible with i.MX6SX, but it doesn't have the
power-domain requirement. Limit the i.MX6SX power-domains requirement to
i.MX6SX only.

Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
Signed-off-by: Philipp Zabel <[email protected]>
Signed-off-by: Roland Hieber <[email protected]>
---
Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
index fc11ab5fc465..83532959e51c 100644
--- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
+++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
@@ -117,13 +117,19 @@ allOf:
maxItems: 1
clock-names:
maxItems: 1
+ - if:
+ properties:
+ compatible:
+ const: fsl,imx6sx-lcdif
+ then:
+ required:
+ - power-domains
- if:
properties:
compatible:
contains:
enum:
- fsl,imx6sl-lcdif
- - fsl,imx6sx-lcdif
- fsl,imx8mm-lcdif
- fsl,imx8mn-lcdif
- fsl,imx8mp-lcdif

---
base-commit: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
change-id: 20231127-b4-dt-bindings-mxsfb-9a0676d08b4c

Best regards,
--
Roland Hieber, Pengutronix e.K. | [email protected] |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2023-11-27 17:31:27

by Conor Dooley

[permalink] [raw]

Subject: Re: [PATCH] dt-bindings: mxsfb: Remove power-domains requirements for i.MX7D

---

On Mon, Nov 27, 2023 at 04:35:56PM +0100, Roland Hieber wrote:
> From: Philipp Zabel <[email protected]>
>
> i.MX7D is documented as compatible with i.MX6SX, but it doesn't have the
> power-domain requirement. Limit the i.MX6SX power-domains requirement to
> i.MX6SX only.

I dont like this commit message tbh, I shouldn't have to go and dig out the
file to be able to understand what you are doing here - it should really be
explained that the imx7d falls back to the imx6sx, as otherwise this looks
like nothing at all to do with with imx7d.

Thanks,
Conor.

>
> Fixes: f62678a77d58 ("dt-bindings: mxsfb: Document i.MX8M/i.MX6SX/i.MX6SL power-domains property")
> Signed-off-by: Philipp Zabel <[email protected]>
> Signed-off-by: Roland Hieber <[email protected]>
> ---
> Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index fc11ab5fc465..83532959e51c 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -117,13 +117,19 @@ allOf:
> maxItems: 1
> clock-names:
> maxItems: 1
> + - if:
> + properties:
> + compatible:
> + const: fsl,imx6sx-lcdif
> + then:
> + required:
> + - power-domains
> - if:
> properties:
> compatible:
> contains:
> enum:
> - fsl,imx6sl-lcdif
> - - fsl,imx6sx-lcdif
> - fsl,imx8mm-lcdif
> - fsl,imx8mn-lcdif
> - fsl,imx8mp-lcdif
>
> ---
> base-commit: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
> change-id: 20231127-b4-dt-bindings-mxsfb-9a0676d08b4c
>
> Best regards,
> --
> Roland Hieber, Pengutronix e.K. | [email protected] |
> Steuerwalder Str. 21 | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
>

---

Attachments:

(No filename) (2.21 kB)
signature.asc (235.00 B)
Download all attachments