2023-11-26 16:39:44

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: hmc425a: add entry for ADRF5740 Attenuator

On Mon, 13 Nov 2023 13:41:27 +0000
Conor Dooley <[email protected]> wrote:

> On Mon, Nov 13, 2023 at 01:40:40PM +0000, Conor Dooley wrote:
> > On Mon, Nov 13, 2023 at 12:25:35PM +0200, Ana-Maria Cusco wrote:
> > > From: Ana-Maria Cusco <[email protected]>
> > >
> > > The ADRF5740 is a silicon, 4-bit digital attenuator with 22 dB
> > > attenuation control range in 2 dB steps.
> > >
> > > Signed-off-by: Ana-Maria Cusco <[email protected]>
> >
> > Acked-by: Conor Dooley <[email protected]>
>
> One thing though, the bindings patch should come before the driver patch
> in your series.
Flipped order whilst applying.

Applied to the togreg branch of iio.git an pushed out initially as
testing for 0-day to poke at it and see if it can find anythign we missed.

Trivial thing but Ana-Maria, I'd prefer a cover letter even on a short series
like this. It provides a place for general comments / discussion / tags to be
applied and it gives it a pretty name in patchwork.

Jonathan


>
> Thanks,
> conor.


2023-11-27 17:48:55

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] dt-bindings: iio: hmc425a: add entry for ADRF5740 Attenuator

On Sun, Nov 26, 2023 at 04:39:22PM +0000, Jonathan Cameron wrote:

> Trivial thing but Ana-Maria, I'd prefer a cover letter even on a short series
> like this. It provides a place for general comments / discussion / tags to be
> applied and it gives it a pretty name in patchwork.

It also helps patchwork detect when things are a later revision and mark
the old ones as superseded, which is rather nice :)


Attachments:
(No filename) (415.00 B)
signature.asc (235.00 B)
Download all attachments