2023-11-27 02:04:44

by Chen Ni

Subject: [PATCH v2] crypto: sa2ul - Return crypto_aead_setkey to transfer the error

Return crypto_aead_setkey() in order to transfer the error if
it fails.

Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support")
Signed-off-by: Chen Ni <[email protected]>
---
Changelog:

v1 -> v2:
1. Simplify code
2. Update commit message
---
drivers/crypto/sa2ul.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c
index 6846a8429574..78a4930c6480 100644
--- a/drivers/crypto/sa2ul.c
+++ b/drivers/crypto/sa2ul.c
@@ -1869,9 +1869,8 @@ static int sa_aead_setkey(struct crypto_aead *authenc,
crypto_aead_set_flags(ctx->fallback.aead,
crypto_aead_get_flags(authenc) &
CRYPTO_TFM_REQ_MASK);
- crypto_aead_setkey(ctx->fallback.aead, key, keylen);

- return 0;
+ return crypto_aead_setkey(ctx->fallback.aead, key, keylen);
}

static int sa_aead_setauthsize(struct crypto_aead *tfm, unsigned int authsize)
--
2.25.1

2023-12-01 11:18:27

by Herbert Xu

Subject: Re: [PATCH v2] crypto: sa2ul - Return crypto_aead_setkey to transfer the error

On Mon, Nov 27, 2023 at 02:03:01AM +0000, Chen Ni wrote:
> Return crypto_aead_setkey() in order to transfer the error if
> it fails.
>
> Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support")
> Signed-off-by: Chen Ni <[email protected]>
> ---
> Changelog:
>
> v1 -> v2:
> 1. Simplify code
> 2. Update commit message
> ---
> drivers/crypto/sa2ul.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt