2023-11-26 09:26:28

by Tomas Winkler

Subject: [char-misc-linus for v6.7-rc3 V2] mei: pxp: fix mei_pxp_send_message return value

From: Alexander Usyskin <[email protected]>

mei_pxp_send_message() should return zero on success and
cannot propagate number of bytes as returned by internally
called mei_cldev_send().

Fixes: ee5cb39348e6 ("mei: pxp: recover from recv fail under memory pressure")
Signed-off-by: Alexander Usyskin <[email protected]>
Signed-off-by: Tomas Winkler <[email protected]>
---
V2: This is a resent for https://lkml.org/lkml/2023/10/31/636
drivers/misc/mei/pxp/mei_pxp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/mei/pxp/mei_pxp.c b/drivers/misc/mei/pxp/mei_pxp.c
index f77d78fa50549e69f0a0873b..787c6a27a4be60f9322c6aad 100644
--- a/drivers/misc/mei/pxp/mei_pxp.c
+++ b/drivers/misc/mei/pxp/mei_pxp.c
@@ -84,9 +84,10 @@ mei_pxp_send_message(struct device *dev, const void *message, size_t size, unsig
byte = ret;
break;
}
+ return byte;
}

- return byte;
+ return 0;
}

/**
--
2.43.0

2023-11-27 13:55:49

by Greg Kroah-Hartman

Subject: Re: [char-misc-linus for v6.7-rc3 V2] mei: pxp: fix mei_pxp_send_message return value

On Sun, Nov 26, 2023 at 11:24:49AM +0200, Tomas Winkler wrote:
> From: Alexander Usyskin <[email protected]>
>
> mei_pxp_send_message() should return zero on success and
> cannot propagate number of bytes as returned by internally
> called mei_cldev_send().
>
> Fixes: ee5cb39348e6 ("mei: pxp: recover from recv fail under memory pressure")
> Signed-off-by: Alexander Usyskin <[email protected]>
> Signed-off-by: Tomas Winkler <[email protected]>
> ---
> V2: This is a resent for https://lkml.org/lkml/2023/10/31/636

Nit, please use lore.kernel.org, we have no idea who runs lkml.org and
it really doesn't work well for actual development.

thanks,

greg k-h