2023-11-28 09:01:34

by Lukas Bulwahn

[permalink] [raw]
Subject: [PATCH RESEND] x86/Kconfig: Remove obsolete config X86_32_SMP

Commit 0f08c3b22996 ("x86/smp: Reduce code duplication") removes the only
use of CONFIG_X86_32_SMP.

Remove the obsolete config X86_32_SMP.

Signed-off-by: Lukas Bulwahn <[email protected]>
---

I sent this cleanup patch in March 2023 and it did not get any attention:

https://lore.kernel.org/lkml/[email protected]/

It is just minor cleanup, but it also should not cause any issue.
This can be quickly checked with grep "X86_32_SMP" . -R and seeing that
this is only mentioned in arch/x86/Kconfig in this one definition.

No change here other than rebasing the original patch.

arch/x86/Kconfig | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 21890efbfdd8..d7d1ef3d2684 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -384,10 +384,6 @@ config HAVE_INTEL_TXT
def_bool y
depends on INTEL_IOMMU && ACPI

-config X86_32_SMP
- def_bool y
- depends on X86_32 && SMP
-
config X86_64_SMP
def_bool y
depends on X86_64 && SMP
--
2.17.1


Subject: [tip: x86/cleanups] x86/Kconfig: Remove obsolete config X86_32_SMP

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID: c64545594daf748422fa083389b062d0a16fb477
Gitweb: https://git.kernel.org/tip/c64545594daf748422fa083389b062d0a16fb477
Author: Lukas Bulwahn <[email protected]>
AuthorDate: Tue, 28 Nov 2023 10:00:16 +01:00
Committer: Borislav Petkov (AMD) <[email protected]>
CommitterDate: Tue, 28 Nov 2023 13:31:34 +01:00

x86/Kconfig: Remove obsolete config X86_32_SMP

Commit

0f08c3b22996 ("x86/smp: Reduce code duplication")

removed the only use of CONFIG_X86_32_SMP.

Remove the now obsolete config X86_32_SMP too.

Signed-off-by: Lukas Bulwahn <[email protected]>
Signed-off-by: Borislav Petkov (AMD) <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
arch/x86/Kconfig | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 3762f41..5a6728d 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -384,10 +384,6 @@ config HAVE_INTEL_TXT
def_bool y
depends on INTEL_IOMMU && ACPI

-config X86_32_SMP
- def_bool y
- depends on X86_32 && SMP
-
config X86_64_SMP
def_bool y
depends on X86_64 && SMP

2023-11-28 16:28:32

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH RESEND] x86/Kconfig: Remove obsolete config X86_32_SMP



On 11/28/23 01:00, Lukas Bulwahn wrote:
> Commit 0f08c3b22996 ("x86/smp: Reduce code duplication") removes the only
> use of CONFIG_X86_32_SMP.
>
> Remove the obsolete config X86_32_SMP.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
>
> I sent this cleanup patch in March 2023 and it did not get any attention:
>
> https://lore.kernel.org/lkml/[email protected]/
>
> It is just minor cleanup, but it also should not cause any issue.
> This can be quickly checked with grep "X86_32_SMP" . -R and seeing that
> this is only mentioned in arch/x86/Kconfig in this one definition.
>
> No change here other than rebasing the original patch.
>
> arch/x86/Kconfig | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 21890efbfdd8..d7d1ef3d2684 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -384,10 +384,6 @@ config HAVE_INTEL_TXT
> def_bool y
> depends on INTEL_IOMMU && ACPI
>
> -config X86_32_SMP
> - def_bool y
> - depends on X86_32 && SMP
> -
> config X86_64_SMP
> def_bool y
> depends on X86_64 && SMP

--
~Randy