Hi Yi,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
commit: c1cce6d079b875396c9a7c6838fc5b024758e540 vfio: Compile vfio_group infrastructure optionally
date: 4 months ago
config: powerpc64-randconfig-002-20231128 (https://download.01.org/0day-ci/archive/20231128/[email protected]/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231128/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> arch/powerpc/kvm/../../../virt/kvm/vfio.c:89:7: warning: attribute declaration must precede definition [-Wignored-attributes]
fn = symbol_get(vfio_file_iommu_group);
^
include/linux/module.h:805:60: note: expanded from macro 'symbol_get'
#define symbol_get(x) ({ extern typeof(x) x __attribute__((weak,visibility("hidden"))); &(x); })
^
include/linux/vfio.h:294:35: note: previous definition is here
static inline struct iommu_group *vfio_file_iommu_group(struct file *file)
^
>> arch/powerpc/kvm/../../../virt/kvm/vfio.c:89:7: warning: attribute declaration must precede definition [-Wignored-attributes]
fn = symbol_get(vfio_file_iommu_group);
^
include/linux/module.h:805:65: note: expanded from macro 'symbol_get'
#define symbol_get(x) ({ extern typeof(x) x __attribute__((weak,visibility("hidden"))); &(x); })
^
include/linux/vfio.h:294:35: note: previous definition is here
static inline struct iommu_group *vfio_file_iommu_group(struct file *file)
^
2 warnings generated.
vim +89 arch/powerpc/kvm/../../../virt/kvm/vfio.c
4b22ef042d6f54 Jason Gunthorpe 2022-10-07 82
4b22ef042d6f54 Jason Gunthorpe 2022-10-07 83 #ifdef CONFIG_SPAPR_TCE_IOMMU
50d63b5bbfd122 Jason Gunthorpe 2022-05-04 84 static struct iommu_group *kvm_vfio_file_iommu_group(struct file *file)
121f80ba68f1a5 Alexey Kardashevskiy 2017-03-22 85 {
50d63b5bbfd122 Jason Gunthorpe 2022-05-04 86 struct iommu_group *(*fn)(struct file *file);
50d63b5bbfd122 Jason Gunthorpe 2022-05-04 87 struct iommu_group *ret;
121f80ba68f1a5 Alexey Kardashevskiy 2017-03-22 88
50d63b5bbfd122 Jason Gunthorpe 2022-05-04 @89 fn = symbol_get(vfio_file_iommu_group);
121f80ba68f1a5 Alexey Kardashevskiy 2017-03-22 90 if (!fn)
50d63b5bbfd122 Jason Gunthorpe 2022-05-04 91 return NULL;
121f80ba68f1a5 Alexey Kardashevskiy 2017-03-22 92
50d63b5bbfd122 Jason Gunthorpe 2022-05-04 93 ret = fn(file);
121f80ba68f1a5 Alexey Kardashevskiy 2017-03-22 94
50d63b5bbfd122 Jason Gunthorpe 2022-05-04 95 symbol_put(vfio_file_iommu_group);
121f80ba68f1a5 Alexey Kardashevskiy 2017-03-22 96
121f80ba68f1a5 Alexey Kardashevskiy 2017-03-22 97 return ret;
121f80ba68f1a5 Alexey Kardashevskiy 2017-03-22 98 }
121f80ba68f1a5 Alexey Kardashevskiy 2017-03-22 99
:::::: The code at line 89 was first introduced by commit
:::::: 50d63b5bbfd12262069ad062611cd5e69c5e9e05 vfio: Change vfio_external_user_iommu_id() to vfio_file_iommu_group()
:::::: TO: Jason Gunthorpe <[email protected]>
:::::: CC: Alex Williamson <[email protected]>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
On Tue, Nov 28, 2023 at 11:01:45AM +0800, kernel test robot wrote:
> Hi Yi,
>
> FYI, the error/warning still remains.
The patch is still here:
https://lore.kernel.org/r/[email protected]
Alex? Maybe you should send it to -rc now?
Thanks
Jason
On Tue, 28 Nov 2023 08:45:38 -0400
Jason Gunthorpe <[email protected]> wrote:
> On Tue, Nov 28, 2023 at 11:01:45AM +0800, kernel test robot wrote:
> > Hi Yi,
> >
> > FYI, the error/warning still remains.
>
> The patch is still here:
>
> https://lore.kernel.org/r/[email protected]
>
> Alex? Maybe you should send it to -rc now?
Looks like this was originally targeted going through KVM. I'm
intending to do a v6.7-rc pull anyway and it's relevant to vfio, so I
don't mind including it, but I think we need an ack from Paolo.
Paolo?
Thanks,
Alex