2023-11-29 03:00:41

by Pin-yen Lin

Subject: [PATCH v2] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data

This log message is necessary for debugging, so enable it by default to
debug issues that are hard to reproduce locally.

Signed-off-by: Pin-yen Lin <[email protected]>

---

Changes in v2:
- Use dev_warn() instead of dev_err()

drivers/mmc/host/mtk-sd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 97f7c3d4be6e..907c13d746c1 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1150,8 +1150,8 @@ static void msdc_recheck_sdio_irq(struct msdc_host *host)
static void msdc_track_cmd_data(struct msdc_host *host, struct mmc_command *cmd)
{
if (host->error)
- dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
- __func__, cmd->opcode, cmd->arg, host->error);
+ dev_warn(host->dev, "%s: cmd=%d arg=%08X; host->error=0x%08X\n",
+ __func__, cmd->opcode, cmd->arg, host->error);
}

static void msdc_request_done(struct msdc_host *host, struct mmc_request *mrq)
--
2.43.0.rc1.413.gea7ed67945-goog

2023-11-29 07:54:06

by Wenbin Mei (梅文彬)

Subject: Re: [PATCH v2] mmc: mtk-sd: Increase the verbosity of msdc_track_cmd_data

On Wed, 2023-11-29 at 10:59 +0800, Pin-yen Lin wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> This log message is necessary for debugging, so enable it by default
> to
> debug issues that are hard to reproduce locally.
>
> Signed-off-by: Pin-yen Lin <[email protected]>
>
> ---
>
> Changes in v2:
> - Use dev_warn() instead of dev_err()
>
> drivers/mmc/host/mtk-sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 97f7c3d4be6e..907c13d746c1 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1150,8 +1150,8 @@ static void msdc_recheck_sdio_irq(struct
> msdc_host *host)
> static void msdc_track_cmd_data(struct msdc_host *host, struct
> mmc_command *cmd)
> {
> if (host->error)
> - dev_dbg(host->dev, "%s: cmd=%d arg=%08X; host-
> >error=0x%08X\n",
> - __func__, cmd->opcode, cmd->arg, host->error);
> + dev_warn(host->dev, "%s: cmd=%d arg=%08X; host-
> >error=0x%08X\n",
> + __func__, cmd->opcode, cmd->arg, host->error);


Hi Pin-yen,

Thanks for your changes!
Indeed, these logs are necessary for us to debug, but the crc errors
during the tuning process
are expected and we don't want them to be printed.
The timeout errors during the tuning process are unexpected and should
be printed.

So we can change it as below:
if (host->error) {
if ((!mmc_op_tuning(cmd->opcode) && !host->hs400_tuning) ||
cmd->error == -ETIMEDOUT) {
dev_warn(host->dev, "%s: cmd=%d arg=%08X; host-
>error=0x%08X\n", __func__, cmd->opcode, cmd->arg, host->error);
}
}

Best regards,
Wenbin

> }
>
> static void msdc_request_done(struct msdc_host *host, struct
> mmc_request *mrq)
> --
> 2.43.0.rc1.413.gea7ed67945-goog
>