2023-11-28 17:50:46

by Andy Shevchenko

Subject: [PATCH net-next v1 1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition

BYTES_PER_KBIT is defined in units.h, use that definition.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/net/dsa/sja1105/sja1105_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index 74cee39d73df..6646f7fb0f90 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c
@@ -21,6 +21,8 @@
#include <linux/if_bridge.h>
#include <linux/if_ether.h>
#include <linux/dsa/8021q.h>
+#include <linux/units.h>
+
#include "sja1105.h"
#include "sja1105_tas.h"

@@ -2138,7 +2140,6 @@ static void sja1105_bridge_leave(struct dsa_switch *ds, int port,
sja1105_bridge_member(ds, port, bridge, false);
}

-#define BYTES_PER_KBIT (1000LL / 8)
/* Port 0 (the uC port) does not have CBS shapers */
#define SJA1110_FIXED_CBS(port, prio) ((((port) - 1) * SJA1105_NUM_TC) + (prio))

--
2.43.0.rc1.1.gbec44491f096

2023-11-29 12:20:53

by Vladimir Oltean

Subject: Re: [PATCH net-next v1 1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition

On Tue, Nov 28, 2023 at 07:50:27PM +0200, Andy Shevchenko wrote:
> BYTES_PER_KBIT is defined in units.h, use that definition.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---

Reviewed-by: Vladimir Oltean <[email protected]>

2023-11-30 04:21:03

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next v1 1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Tue, 28 Nov 2023 19:50:27 +0200 you wrote:
> BYTES_PER_KBIT is defined in units.h, use that definition.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/net/dsa/sja1105/sja1105_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
- [net-next,v1,1/1] net: dsa: sja1105: Use units.h instead of the copy of a definition
https://git.kernel.org/netdev/net-next/c/4b86d7c64e8f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html