2023-11-29 18:23:44

by Vladimir Oltean

[permalink] [raw]
Subject: Re: [PATCH net-next v8 3/9] ARM: dts: marvell: Fix some common switch mistakes

On Tue, Nov 14, 2023 at 12:35:58AM +0100, Linus Walleij wrote:
> Fix some errors in the Marvell MV88E6xxx switch descriptions:
> - The top node had no address size or cells.
> - switch0@0 is not OK, should be ethernet-switch@0.
> - The ports node should be named ethernet-ports
> - The ethernet-ports node should have port@0 etc children, no
> plural "ports" in the children.
> - Ports should be named ethernet-port@0 etc
> - PHYs should be named ethernet-phy@0 etc
>
> This serves as an example of fixes needed for introducing a
> schema for the bindings, but the patch can simply be applied.
>
> Reviewed-by: Andrew Lunn <[email protected]>
> Reviewed-by: Florian Fainelli <[email protected]>
> Signed-off-by: Linus Walleij <[email protected]>
> ---

Reviewed-by: Vladimir Oltean <[email protected]>