2023-11-29 22:21:52

by David E. Box

Subject: [PATCH V6 02/20] platform/x86/intel/vsec: Remove unnecessary return

In intel_vsec_add_aux(), just return from the last call to
devm_add_action_or_reset() instead of checking its return value.

Suggested-by: Ilpo Järvinen <[email protected]>
Signed-off-by: David E. Box <[email protected]>
---
V6 - New patch

drivers/platform/x86/intel/vsec.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
index 2d568466b4e2..340562ae2041 100644
--- a/drivers/platform/x86/intel/vsec.c
+++ b/drivers/platform/x86/intel/vsec.c
@@ -174,12 +174,8 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
return ret;
}

- ret = devm_add_action_or_reset(parent, intel_vsec_remove_aux,
+ return devm_add_action_or_reset(parent, intel_vsec_remove_aux,
auxdev);
- if (ret < 0)
- return ret;
-
- return 0;
}
EXPORT_SYMBOL_NS_GPL(intel_vsec_add_aux, INTEL_VSEC);

--
2.34.1

2023-11-30 11:03:18

by Ilpo Järvinen

Subject: Re: [PATCH V6 02/20] platform/x86/intel/vsec: Remove unnecessary return

On Wed, 29 Nov 2023, David E. Box wrote:

> In intel_vsec_add_aux(), just return from the last call to
> devm_add_action_or_reset() instead of checking its return value.
>
> Suggested-by: Ilpo Järvinen <[email protected]>
> Signed-off-by: David E. Box <[email protected]>
> ---
> V6 - New patch
>
> drivers/platform/x86/intel/vsec.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
> index 2d568466b4e2..340562ae2041 100644
> --- a/drivers/platform/x86/intel/vsec.c
> +++ b/drivers/platform/x86/intel/vsec.c
> @@ -174,12 +174,8 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent,
> return ret;
> }
>
> - ret = devm_add_action_or_reset(parent, intel_vsec_remove_aux,
> + return devm_add_action_or_reset(parent, intel_vsec_remove_aux,
> auxdev);
> - if (ret < 0)
> - return ret;
> -
> - return 0;
> }
> EXPORT_SYMBOL_NS_GPL(intel_vsec_add_aux, INTEL_VSEC);

Reviewed-by: Ilpo Järvinen <[email protected]>


--
i.