The hall sensor interrupt on the Primus is active low, which means that
with the current configuration the device attempts to suspend when the
LID is open.
Fix the polarity of the HALL_INT GPIO to avoid this.
Fixes: 2ce38cc1e8fe ("arm64: dts: qcom: sc8180x: Introduce Primus")
Signed-off-by: Bjorn Andersson <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x-primus.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
index fd2fab4895b3..a40ef23a2a4f 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-primus.dts
@@ -43,7 +43,7 @@ gpio-keys {
pinctrl-0 = <&hall_int_active_state>;
lid-switch {
- gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>;
+ gpios = <&tlmm 121 GPIO_ACTIVE_LOW>;
linux,input-type = <EV_SW>;
linux,code = <SW_LID>;
wakeup-source;
---
base-commit: 3cd3fe06ff81cfb3a969acb12a56796cff5af23d
change-id: 20231130-sc8180x-primus-lid-polarity-54aa6405f61d
Best regards,
--
Bjorn Andersson <[email protected]>
On 1.12.2023 01:11, Bjorn Andersson wrote:
> The hall sensor interrupt on the Primus is active low, which means that
> with the current configuration the device attempts to suspend when the
> LID is open.
>
> Fix the polarity of the HALL_INT GPIO to avoid this.
>
> Fixes: 2ce38cc1e8fe ("arm64: dts: qcom: sc8180x: Introduce Primus")
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
On Thu, 30 Nov 2023 16:11:10 -0800, Bjorn Andersson wrote:
> The hall sensor interrupt on the Primus is active low, which means that
> with the current configuration the device attempts to suspend when the
> LID is open.
>
> Fix the polarity of the HALL_INT GPIO to avoid this.
>
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sc8180x-primus: Fix HALL_INT polarity
commit: 1aaa08e8de365cce59203541cafadb5053b1ec1a
Best regards,
--
Bjorn Andersson <[email protected]>