2023-11-25 10:38:57

by Masahiro Yamada

Subject: [PATCH 1/3] modpost: move __attribute__((format(printf, 2, 3))) to modpost.h

This attribute must be added to the function declaration in a header
for comprehensive checking of all the callsites.

Fixes: 6d9a89ea4b06 ("kbuild: declare the modpost error functions as printf like")
Signed-off-by: Masahiro Yamada <[email protected]>
---

scripts/mod/modpost.c | 3 +--
scripts/mod/modpost.h | 3 ++-
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index cb6406f485a9..ca0a90158f85 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -60,8 +60,7 @@ static unsigned int nr_unresolved;

#define MODULE_NAME_LEN (64 - sizeof(Elf_Addr))

-void __attribute__((format(printf, 2, 3)))
-modpost_log(enum loglevel loglevel, const char *fmt, ...)
+void modpost_log(enum loglevel loglevel, const char *fmt, ...)
{
va_list arglist;

diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h
index 69baf014da4f..9fe974dc1a52 100644
--- a/scripts/mod/modpost.h
+++ b/scripts/mod/modpost.h
@@ -197,7 +197,8 @@ enum loglevel {
LOG_FATAL
};

-void modpost_log(enum loglevel loglevel, const char *fmt, ...);
+void __attribute__((format(printf, 2, 3)))
+modpost_log(enum loglevel loglevel, const char *fmt, ...);

/*
* warn - show the given message, then let modpost continue running, still
--
2.40.1

2023-11-30 00:17:14

by Nathan Chancellor

Subject: Re: [PATCH 1/3] modpost: move __attribute__((format(printf, 2, 3))) to modpost.h

On Sat, Nov 25, 2023 at 07:31:14PM +0900, Masahiro Yamada wrote:
> This attribute must be added to the function declaration in a header
> for comprehensive checking of all the callsites.
>
> Fixes: 6d9a89ea4b06 ("kbuild: declare the modpost error functions as printf like")
> Signed-off-by: Masahiro Yamada <[email protected]>

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
>
> scripts/mod/modpost.c | 3 +--
> scripts/mod/modpost.h | 3 ++-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index cb6406f485a9..ca0a90158f85 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -60,8 +60,7 @@ static unsigned int nr_unresolved;
>
> #define MODULE_NAME_LEN (64 - sizeof(Elf_Addr))
>
> -void __attribute__((format(printf, 2, 3)))
> -modpost_log(enum loglevel loglevel, const char *fmt, ...)
> +void modpost_log(enum loglevel loglevel, const char *fmt, ...)
> {
> va_list arglist;
>
> diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h
> index 69baf014da4f..9fe974dc1a52 100644
> --- a/scripts/mod/modpost.h
> +++ b/scripts/mod/modpost.h
> @@ -197,7 +197,8 @@ enum loglevel {
> LOG_FATAL
> };
>
> -void modpost_log(enum loglevel loglevel, const char *fmt, ...);
> +void __attribute__((format(printf, 2, 3)))
> +modpost_log(enum loglevel loglevel, const char *fmt, ...);
>
> /*
> * warn - show the given message, then let modpost continue running, still
> --
> 2.40.1
>