2023-11-29 08:29:43

by Can Guo

Subject: [PATCH v6 09/10] scsi: ufs: ufs-qcom: Check return value of phy_set_mode_ext()

In ufs_qcom_power_up_sequence(), check return value of phy_set_mode_ext()
and stop proceeding if phy_set_mode_ext() fails.

Signed-off-by: Can Guo <[email protected]>
---
drivers/ufs/host/ufs-qcom.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 30f4ca6..9c0ebbc 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -475,7 +475,12 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
return ret;
}

- phy_set_mode_ext(phy, mode, host->phy_gear);
+ ret = phy_set_mode_ext(phy, mode, host->phy_gear);
+ if (ret) {
+ dev_err(hba->dev, "%s: phy set mode failed, ret = %d\n",
+ __func__, ret);
+ goto out_disable_phy;
+ }

/* power on phy - start serdes and phy's power and clocks */
ret = phy_power_on(phy);
--
2.7.4

2023-11-29 08:39:38

by Nitin Rawat

Subject: Re: [PATCH v6 09/10] scsi: ufs: ufs-qcom: Check return value of phy_set_mode_ext()

On 11/29/2023 1:58 PM, Can Guo wrote:
> In ufs_qcom_power_up_sequence(), check return value of phy_set_mode_ext()
> and stop proceeding if phy_set_mode_ext() fails.
>
> Signed-off-by: Can Guo <[email protected]>
> ---
> drivers/ufs/host/ufs-qcom.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 30f4ca6..9c0ebbc 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -475,7 +475,12 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
> return ret;
> }
>
> - phy_set_mode_ext(phy, mode, host->phy_gear);
> + ret = phy_set_mode_ext(phy, mode, host->phy_gear);
> + if (ret) {
> + dev_err(hba->dev, "%s: phy set mode failed, ret = %d\n",
> + __func__, ret);
> + goto out_disable_phy;
> + }
>
> /* power on phy - start serdes and phy's power and clocks */
> ret = phy_power_on(phy);

Reviewed-by: Nitin Rawat <[email protected]>

2023-11-30 07:17:04

by Manivannan Sadhasivam

Subject: Re: [PATCH v6 09/10] scsi: ufs: ufs-qcom: Check return value of phy_set_mode_ext()

On Wed, Nov 29, 2023 at 12:28:34AM -0800, Can Guo wrote:
> In ufs_qcom_power_up_sequence(), check return value of phy_set_mode_ext()
> and stop proceeding if phy_set_mode_ext() fails.
>
> Signed-off-by: Can Guo <[email protected]>
> ---
> drivers/ufs/host/ufs-qcom.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 30f4ca6..9c0ebbc 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -475,7 +475,12 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
> return ret;
> }
>
> - phy_set_mode_ext(phy, mode, host->phy_gear);
> + ret = phy_set_mode_ext(phy, mode, host->phy_gear);
> + if (ret) {
> + dev_err(hba->dev, "%s: phy set mode failed, ret = %d\n",
> + __func__, ret);

No need to print the error message here as it is already done in the PHY driver.

Also, this patch should come before the PHY patch returning error.

- Mani

> + goto out_disable_phy;
> + }
>
> /* power on phy - start serdes and phy's power and clocks */
> ret = phy_power_on(phy);
> --
> 2.7.4
>
>

--
மணிவண்ணன் சதாசிவம்

2023-11-30 08:20:31

by Can Guo

Subject: Re: [PATCH v6 09/10] scsi: ufs: ufs-qcom: Check return value of phy_set_mode_ext()

On 11/30/2023 3:16 PM, Manivannan Sadhasivam wrote:
> On Wed, Nov 29, 2023 at 12:28:34AM -0800, Can Guo wrote:
>> In ufs_qcom_power_up_sequence(), check return value of phy_set_mode_ext()
>> and stop proceeding if phy_set_mode_ext() fails.
>>
>> Signed-off-by: Can Guo <[email protected]>
>> ---
>> drivers/ufs/host/ufs-qcom.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
>> index 30f4ca6..9c0ebbc 100644
>> --- a/drivers/ufs/host/ufs-qcom.c
>> +++ b/drivers/ufs/host/ufs-qcom.c
>> @@ -475,7 +475,12 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
>> return ret;
>> }
>>
>> - phy_set_mode_ext(phy, mode, host->phy_gear);
>> + ret = phy_set_mode_ext(phy, mode, host->phy_gear);
>> + if (ret) {
>> + dev_err(hba->dev, "%s: phy set mode failed, ret = %d\n",
>> + __func__, ret);
>
> No need to print the error message here as it is already done in the PHY driver.
>
> Also, this patch should come before the PHY patch returning error.

Sure.

Thanks,
Can Guo.

>
> - Mani
>
>> + goto out_disable_phy;
>> + }
>>
>> /* power on phy - start serdes and phy's power and clocks */
>> ret = phy_power_on(phy);
>> --
>> 2.7.4
>>
>>
>