2023-11-30 14:32:29

by Andy Shevchenko

Subject: [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()

The pci_alloc_irq_vectors() returns a positive number on success.
Hence we have to filter the negative numbers for error condition.
Update the check accordingly.

Fixes: e6951fb78787 ("mfd: intel-lpss: Use PCI APIs instead of dereferencing")
Reported-by: Heikki Krogerus <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/mfd/intel-lpss-pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
index 8f5e10817a9c..4621d3950b8f 100644
--- a/drivers/mfd/intel-lpss-pci.c
+++ b/drivers/mfd/intel-lpss-pci.c
@@ -44,7 +44,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
return ret;

ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
- if (ret)
+ if (ret < 0)
return ret;

info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL);
--
2.43.0.rc1.1.gbec44491f096

2023-11-30 14:44:51

by Heikki Krogerus

Subject: Re: [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()

On Thu, Nov 30, 2023 at 04:32:06PM +0200, Andy Shevchenko wrote:
> The pci_alloc_irq_vectors() returns a positive number on success.
> Hence we have to filter the negative numbers for error condition.
> Update the check accordingly.
>
> Fixes: e6951fb78787 ("mfd: intel-lpss: Use PCI APIs instead of dereferencing")
> Reported-by: Heikki Krogerus <[email protected]>
> Signed-off-by: Andy Shevchenko <[email protected]>

Thanks for the quick fix.

Tested-by: Heikki Krogerus <[email protected]>

> ---
> drivers/mfd/intel-lpss-pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 8f5e10817a9c..4621d3950b8f 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -44,7 +44,7 @@ static int intel_lpss_pci_probe(struct pci_dev *pdev,
> return ret;
>
> ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_LEGACY);
> - if (ret)
> + if (ret < 0)
> return ret;
>
> info = devm_kmemdup(&pdev->dev, data, sizeof(*info), GFP_KERNEL);

thanks,

--
heikki

2023-12-01 11:32:28

by Lee Jones

Subject: Re: (subset) [PATCH v1 1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()

On Thu, 30 Nov 2023 16:32:06 +0200, Andy Shevchenko wrote:
> The pci_alloc_irq_vectors() returns a positive number on success.
> Hence we have to filter the negative numbers for error condition.
> Update the check accordingly.
>
>

Applied, thanks!

[1/1] mfd: intel-lpss: Don't fail probe on success of pci_alloc_irq_vectors()
commit: d1432c3fc6c1d6a3fe9ab20332ac01336ee98371

--
Lee Jones [李琼斯]